New issue
Advanced search Search tips

Issue 605007 link

Starred by 1 user
Status: Fixed
Owner:
azurewei@chromium.org
Closed: Apr 2016
Cc:
shuchen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Duplicated onActivate event when the IME extension is loaded

Project Member Reported by shuchen@chromium.org, Apr 20 2016 
Version: M51
OS: Windows/Linux

What steps will reproduce the problem?
(1) Install the IME extension at https://chrome.google.com/webstore/detail/google-input-tools/pfnpllfaaggnjbkdkpmoalokijekmaec
(2) Enable/Activate an input method, e.g. Chinese Pinyin IME
(3) Restart the browser.

What is the expected output?
The Chinese Pinyin IME can work.

What do you see instead?
The Chinese Pinyin IME cannot work.

The root cause is that the IME extension receives the onActivate event twice so the extension does the duplicated initialization, results in the wrong behaviors.
This can be easily workaround'ed in IME extension, but the API should also be fixed so that 3rd-party IME extensions won't be trapped.

Comment 1 by shuchen@chromium.org, Apr 20 2016

Labels: Merge-Request-51
This issue was fixed in M52 by reverting the regression cl.

Regression cl: https://codereview.chromium.org/1870783003
Revert cl: https://codereview.chromium.org/1883703002

Requesting merge of the revert cl to M51.

Comment 2 by shuchen@chromium.org, Apr 20 2016

Labels: -Pri-3 Pri-1

Comment 3 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 4 by gov...@chromium.org, Apr 22 2016 

Please merge your change to M51 branch 2704 before 5:00 PM PST Monday (04/25/16) so we can take it for Next week M51 Beta candidate cut. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 22 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3350daf0ecc83d914f8dfba7b023a0e3059cd21

commit f3350daf0ecc83d914f8dfba7b023a0e3059cd21
Author: Shu Chen <shuchen@google.com>
Date: Fri Apr 22 01:42:13 2016

Revert "Notifies the IME extension for IME ready with onActivate/onFocus events at start."

This reverts commit 96e3d965e31d8a9d794dc9b8c046467223a3ec6f.

BUG=517773, 605007 
TEST=None

Review URL: https://codereview.chromium.org/1883703002

Cr-Commit-Position: refs/heads/master@{#386907}
(cherry picked from commit 80bdf34b301cb2dfeaffec14909afcee904d941b)

Review URL: https://codereview.chromium.org/1901383002 .

Cr-Commit-Position: refs/branch-heads/2704@{#177}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/f3350daf0ecc83d914f8dfba7b023a0e3059cd21/chrome/browser/extensions/api/input_ime/input_ime_api.cc
[modify] https://crrev.com/f3350daf0ecc83d914f8dfba7b023a0e3059cd21/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
[modify] https://crrev.com/f3350daf0ecc83d914f8dfba7b023a0e3059cd21/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

Comment 6 by shuchen@chromium.org, Apr 22 2016

Status: Fixed (was: Started)

Comment 7 by tkonch...@chromium.org, Apr 27 2016

Labels: TE-Verified-51.0.2704.29 TE-Verified-M51
Tested the same on win7 and Linux 14.04 chrome version 51.0.2704.29 - After activating an input method the corresponding IME works

Please find the screenshot
Screenshot from 2016-04-27 13:33:10.png
848 KB View Download
►

Sign in to add a comment