New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604994 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Card Number field of credit card details doesn't populate under payment information in www.hsn.com.

Reported by mni...@etouch.net, Apr 20 2016

Issue description

Chrome Version : 50.0.2661.86 4604d24a75168768584760ba56d175507941852f-refs/branch-heads/2661@{#615} 32/64 Bit. 
OS:All (Win 7 Aero enabled)

What steps will reproduce the problem?
1.Launch chrome and navigate to chrome://settings/autofill ,click on 'add new new credit card' enter card holder name/card no, expiry month/year
2.Navigate to www.hsn.com ,select any product and add to bag, click on 'checkout' button.
3.Now double click on card no field and observe 

Actual: Card Number field of credit card details doesn't populate under payment information.

Expected: Card Number field credit card details should populate under payment information.

This is a Non-regression issue seen from 'M-30' series i.e 30.0.1552.0
 
Actual_video.mp4
702 KB Download
Actual_screenshot.png
197 KB View Download

Comment 1 by mni...@etouch.net, Apr 20 2016

Labels: -M-50 M-52
Status: Untriaged (was: Unconfirmed)
marking as Untriaged, requesting Dev team to check the issue.

Comment 3 by se...@chromium.org, Apr 20 2016

Cc: zkoch@chromium.org
After investigation, the reason why we fail to offer to fill the credit card number is because that field is contained in an iframe. Since it's the only field present in it, the heuristics are not even ran on it. The expiration dates are out of that iframe and the predictions are good for those.

As a side note, the address fill is really impressive on this site. See screenshot (filled in one shot). 
hsn.png
43.7 KB View Download

Comment 4 by se...@chromium.org, Apr 20 2016

Cc: ma...@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 13 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by ma...@chromium.org, Sep 22 2017

Labels: M-63
Owner: se...@chromium.org
Status: Assigned (was: Untriaged)
iframe issue

Comment 8 by rogerm@chromium.org, Sep 30 2017

Cc: se...@chromium.org
Owner: rogerm@chromium.org
I can get these to work, but its quality depends on the different iframe fields being names/labeled differently from one another. Otherwise, Chrome won't be able to tell which iframe is which.

Keeping this bug (as opposed to marking as dup) as a reminder to go back and check this domain.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8

commit bf55e6a3ad7bd179604804cf79ad084cf55b9dd8
Author: Roger McFarlane <rogerm@chromium.org>
Date: Tue Nov 28 18:55:23 2017

[autofill] Add feature flags to disable requirement of min number of fields.

This CL adds base::Feature flags which independently control the enforcement
of a minimum number of required field for heuristics, queries and uploads.

This allows autofill to:

(1) generally enable uploading of form/field type votes for 1-field and
    2-field forms. This will populate the crowd-sourced predictions for
    these forms.

(2) experiment with expanding the scope of field prediction (both heuristic
    and queried) and filling to single field forms.

The primary motivation for this change is to support single field forms in
payment gateway iframes (usually cc-num or cvc). It will also enable single
Zip code forms (shipping estimates) and email subscription forms.

This CL defaults to the exact same behavior as before the CL: enforcement
of the same minimum value (3) for heuristics, query and upload. The unit
and browser tests have however been updated to test both enforced and
relaxed minimums (unit-tests) and with the upload minimum relaxed (data-
driven browser tests).

TBR: mahmadi, olivierrobin
Bug: 731719, 626785, 604994
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If91ec4c68e1e2d819a03818a6766f0fec9d04e32
Reviewed-on: https://chromium-review.googlesource.com/692674
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519770}
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/chrome/browser/autofill/form_structure_browsertest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/chrome/renderer/autofill/autofill_renderer_browsertest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/chrome/test/data/devtools/dispatch_key_event_shows_auto_fill.html
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/content/renderer/form_cache.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/autofill_merge_unittest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/data_driven_test.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/data_driven_test.h
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/form_field.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/form_field_unittest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/common/autofill_constants.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/core/common/form_field_data.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/017_checkout_advanceautoparts.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/018_checkout_ae.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/019_checkout_bedbathandbeyond.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/024_checkout_homedepot.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/027_checkout_jcrew.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/029_checkout_kohls.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/030_checkout_lowes.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/032_checkout_nordstrom.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/033_checkout_officemax.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/035_checkout_petco.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/036_checkout_petsmart.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/038_checkout_sears.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/040_checkout_urbanoutfitters.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/042_checkout_williams-sonoma.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/046_register_bestbuy.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/048_register_deviantart.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/051_register_epson.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/053_register_gymboree.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/055_register_imdb.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/059_register_macys.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/060_register_mcphee.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/061_register_myspace.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/062_register_newegg.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/063_register_officedepot.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/064_register_officemax.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/065_register_pyramidcollection.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/067_register_rei.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/071_register_sourceforge.net.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/073_register_target.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/074_register_threadless.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/081_crbug_64569.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/094_checkout_staples.com.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/137_bug_555010.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/components/test/data/autofill/heuristics/output/147_panera.custhelp.com_app_ask.out
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/ios/chrome/browser/autofill/autofill_controller_js_unittest.mm
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/ios/chrome/browser/autofill/form_structure_browsertest.mm
[modify] https://crrev.com/bf55e6a3ad7bd179604804cf79ad084cf55b9dd8/ios/chrome/browser/autofill/js_autofill_manager_unittest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e016615d44f4ee387fb434c50f90d3fcf631a9

commit a3e016615d44f4ee387fb434c50f90d3fcf631a9
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Dec 21 00:13:41 2017

[autofill] Put restriction for formless checkout behind a feature flag

This is part of a larger effort to enable small form (less than
three field) autofill for fields embedded in iframes.

Bug:  31719 , 626785, 604994
Change-Id: I9c8562b5b1f93719f5ca82baf829402107b0e028
Reviewed-on: https://chromium-review.googlesource.com/806727
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525528}
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/chrome/browser/autofill/form_structure_browsertest.cc
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/a3e016615d44f4ee387fb434c50f90d3fcf631a9/components/autofill/core/common/form_data.h

Status: Untriaged (was: Assigned)
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment