DevTools DCHECK fails on mouse up |
|||
Issue descriptionOS: Chrome OS on Linux Version: 52.0.2713.0 (Developer Build) (64-bit) Revision: b8a35c3b 1. Open a tab, e.g. about:blank. 2. Open Dev Tools. 3. Position the mouse over the 3-dot Customize menu. 4. Press the left mouse button. 5. Let go. Dev Tools closes. [1:1:0419/195832:FATAL:FlatTreeTraversal.h(129)] Check failed: !node.needsDistributionRecalc(). [29/1998] #0 0x7f4376bf04fe base::debug::StackTrace::StackTrace() #1 0x7f4376c0c81a logging::LogMessage::~LogMessage() #2 0x7f436b7f49c8 blink::FlatTreeTraversal::assertPrecondition() #3 0x7f436bfa5748 blink::parentForClickEvent() #4 0x7f436bf0d91d blink::Node::commonAncestor() #5 0x7f436bfa543f blink::EventHandler::handleMouseReleaseEvent() #6 0x7f43762f9c21 blink::PageWidgetEventHandler::handleMouseUp() #7 0x7f43763730ef blink::WebViewImpl::handleMouseUp() #8 0x7f43762f99b9 blink::PageWidgetDelegate::handleInputEvent() #9 0x7f43763755b3 blink::WebViewImpl::handleInputEvent() #10 0x7f4374dc6655 content::RenderWidgetInputHandler::HandleInputEvent() #11 0x7f4374e50d88 _ZN3IPC8MessageTI30InputMsg_HandleInputEvent_MetaSt5tupleIJPKN5blink13WebInputEventEN2ui11LatencyInfoEN7content22InputEventDispatchTypeEEEvE8DispatchINS9_12RenderWidgetESE_vMSE_FvS6_RKS8_SA_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #12 0x7f4374e5053f content::RenderWidget::OnMessageReceived() #13 0x7f4374e3e25b content::RenderViewImpl::OnMessageReceived() #14 0x7f43737d1128 IPC::MessageRouter::RouteMessage() #15 0x7f43737d1089 IPC::MessageRouter::OnMessageReceived() #16 0x7f4374c35f28 content::ChildThreadImpl::OnMessageReceived() #17 0x7f4374851972 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content21AppCacheURLRequestJobEFvRKNS6_25AppCacheExecutableHandler8ResponseEEEEFvPS7_SB_EJNS_7WeakPtrIS7_EEEEENS0_12InvokeHelperILb1EvSE_EEFvSB_EE3RunEPNS0_13BindStateBas eESB_ #18 0x7f43748acb58 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS_8CallbackIFvRKSt6vectorIN7content21CacheStorageUsageInfoESaIS8_EEELNS0_8CopyModeE1EEESD_JSA_EEENS0_12InvokeHelperILb0EvSF_EEFvvEE3RunEPNS0_13BindStateBaseE #19 0x7f4376bf13a6 base::debug::TaskAnnotator::RunTask() #20 0x7f436ad7da41 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #21 0x7f436ad7c7d5 scheduler::TaskQueueManager::DoWork() #22 0x7f436ad7eb94 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE #23 0x7f4376bf13a6 base::debug::TaskAnnotator::RunTask() #24 0x7f4376c15c35 base::MessageLoop::RunTask() #25 0x7f4376c15f68 base::MessageLoop::DeferOrRunPendingTask() #26 0x7f4376c1617b base::MessageLoop::DoWork() #27 0x7f4376c178bd base::MessagePumpDefault::Run() #28 0x7f4376c157d1 base::MessageLoop::RunHandler() #29 0x7f4376c3a58d base::RunLoop::Run() #30 0x7f4376c14ad0 base::MessageLoop::Run() #31 0x7f4374e5f237 content::RendererMain() #32 0x7f4374 Received signal 67e70ab content::RunZygote() #33 0x7f43747e7ff1 content::ContentMainRunnerImpl::Run() #34 0x7f43747e6ca0 content::ContentMain() #35 0x7f43777eb0ea ChromeMain #36 0x7f436db63ec5 __libc_start_main #37 0x7f43777eaf9f <unknown> Received signal 6 #0 0x7f4376bf0097 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7f436df18340 <unknown> #2 0x7f436db78cc9 gsignal #3 0x7f436db7c0d8 abort #4 0x7f4376beebc2 base::debug::BreakDebugger() #5 0x7f4376c0cad9 logging::LogMessage::~LogMessage() #6 0x7f436b7f49c8 blink::FlatTreeTraversal::assertPrecondition() #7 0x7f436bfa5748 blink::parentForClickEvent() #8 0x7f436bf0d91d blink::Node::commonAncestor() #9 0x7f436bfa543f blink::EventHandler::handleMouseReleaseEvent() #10 0x7f43762f9c21 blink::PageWidgetEventHandler::handleMouseUp() #11 0x7f43763730ef blink::WebViewImpl::handleMouseUp() #12 0x7f43762f99b9 blink::PageWidgetDelegate::handleInputEvent() #13 0x7f43763755b3 blink::WebViewImpl::handleInputEvent() #14 0x7f4374dc6655 content::RenderWidgetInputHandler::HandleInputEvent() #15 0x7f4374e50d88 _ZN3IPC8MessageTI30InputMsg_HandleInputEvent_MetaSt5tupleIJPKN5blink13WebInputEventEN2ui11LatencyInfoEN7content22InputEventDispatchTypeEEEvE8DispatchINS9_12RenderWidgetESE_vMSE_FvS6_RKS8_SA_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #16 0x7f4374e5053f content::RenderWidget::OnMessageReceived() #17 0x7f4374e3e25b content::RenderViewImpl::OnMessageReceived() #18 0x7f43737d1128 IPC::MessageRouter::RouteMessage() #19 0x7f43737d1089 IPC::MessageRouter::OnMessageReceived() #20 0x7f4374c35f28 content::ChildThreadImpl::OnMessageReceived() #21 0x7f4374851972 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content21AppCacheURLRequestJobEFvRKNS6_25AppCacheExecutableHandler8ResponseEEEEFvPS7_SB_EJNS_7WeakPtrIS7_EEEEENS0_12InvokeHelperILb1EvSE_EEFvSB_EE3RunEPNS0_13BindStateBas eESB_ #22 0x7f43748acb58 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS_8CallbackIFvRKSt6vectorIN7content21CacheStorageUsageInfoESaIS8_EEELNS0_8CopyModeE1EEESD_JSA_EEENS0_12InvokeHelperILb0EvSF_EEFvvEE3RunEPNS0_13BindStateBaseE #23 0x7f4376bf13a6 base::debug::TaskAnnotator::RunTask() #24 0x7f436ad7da41 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #25 0x7f436ad7c7d5 scheduler::TaskQueueManager::DoWork() #26 0x7f436ad7eb94 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE #27 0x7f4376bf13a6 base::debug::TaskAnnotator::RunTask() #28 0x7f4376c15c35 base::MessageLoop::RunTask() #29 0x7f4376c15f68 base::MessageLoop::DeferOrRunPendingTask() #30 0x7f4376c1617b base::MessageLoop::DoWork() #31 0x7f4376c178bd base::MessagePumpDefault::Run() #32 0x7f4376c157d1 base::MessageLoop::RunHandler() #33 0x7f4376c3a58d base::RunLoop::Run() #34 0x7f4376c14ad0 base::MessageLoop::Run() #35 0x7f4374e5f237 content::RendererMain() #36 0x7f43747e70ab content::RunZygote() #37 0x7f43747e7ff1 content::ContentMainRunnerImpl::Run() #38 0x7f43747e6ca0 content::ContentMain() #39 0x7f43777eb0ea ChromeMain #40 0x7f436db63ec5 __libc_start_main #41 0x7f43777eaf9f <unknown> r8: ffff8bd2f9681ea8 r9: ffff8bd2f9681e98 r10: 0000000000000008 r11: 0000000000000202 r12: 00003cb86dd4f478 r13: 00003cb86dc224d0 r14: 00007ffd7197b358 r15: 00007ffd7197b348 di: 0000000000000001 si: 0000000000000001 bp: 0000000000000001 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007ffd7197ac28 ip: 00007f436db78cc9 efl: 0000000000000202 cgf: 0045000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace]
,
Apr 20 2016
nzolghadr@ can you look at this assertion in debug mode?
,
Apr 20 2016
I suspect the Node::updateDistribution() call from handleMouseReleaseEvent() returns prematurely w/o checking shadowIncludingRoot()?
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2ee0b0adadd714acbe41ec0e3279243a6885236 commit e2ee0b0adadd714acbe41ec0e3279243a6885236 Author: nzolghadr <nzolghadr@chromium.org> Date: Tue Apr 26 21:57:46 2016 Update distribution on the nodes involved in click Calling updateDistribution function on the nodes that are involved in a click (both mouseup and mousedown nodes) to prevent dchecks when calculating their parents BUG= 604981 Review URL: https://codereview.chromium.org/1907633002 Cr-Commit-Position: refs/heads/master@{#389906} [modify] https://crrev.com/e2ee0b0adadd714acbe41ec0e3279243a6885236/third_party/WebKit/Source/core/input/EventHandler.cpp
,
Apr 26 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by yosin@chromium.org
, Apr 20 2016Labels: -OS-Chrome OS-All