power_LoadTest: update keyboard backlight level based on presence of ALS & hover |
||||||||||
Issue descriptionpower_LoadTest currently sets the keyboard backlight level to 10% for the entire duration of the test. This 10% number was arrived at based on assumptions that ALS would cause the keyboard backlight to be turned off when the ambient light is bright. However, there are devices that have keyboard backlight but do not have ALS (or trackpad hover) and will therefore result in the kb blight to be on most of the time. We should adjust PLT's keyboard backlight to different levels based on presence of ALS and/or trackpad hover. For example: - if neither hover nor ALS are present, set kb blight to the default level. - if ALS is present set kb blight to 50% of default level. - if trackpad hover is present reduce the kb blight by another 25%. The percentages above are examples and should be tweaked based on observed data. Ravi, can you please take a look?
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/85dad304a61986ebeff63f749b5b307d152d74a5 commit 85dad304a61986ebeff63f749b5b307d152d74a5 Author: Ravi Chandra Sadineni <ravisadineni@chromium.org> Date: Wed Apr 27 00:17:16 2016 Adjusting kb backlight based on ALS and Hover. BUG=chromium:604959 CQ-DEPEND=CL:341504, CL:341497, CL:340640, CL:340990 TEST=ran test_that power_LoadTest on pixel2 and passed. Change-Id: I0cf93abe047a256b6c69d5bf70cdf68ff33956a0 Reviewed-on: https://chromium-review.googlesource.com/340881 Commit-Ready: Ravi Chandra Sadineni <ravisadineni@chromium.org> Tested-by: Ravi Chandra Sadineni <ravisadineni@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/85dad304a61986ebeff63f749b5b307d152d74a5/client/site_tests/hardware_Backlight/hardware_Backlight.py [modify] https://crrev.com/85dad304a61986ebeff63f749b5b307d152d74a5/client/cros/power_utils.py [modify] https://crrev.com/85dad304a61986ebeff63f749b5b307d152d74a5/client/site_tests/power_LoadTest/power_LoadTest.py
,
May 12 2016
,
May 12 2016
On systems without hover detection, powerd now turns the backlight on in response to user activity and off thirty seconds later (issue 603233), so presumably the test needs to be updated again, right?
,
May 12 2016
(It's turned on globally but might get turned off on some boards later, so I can add another flag to check_powerd_config to examine this if it'd help.)
,
May 12 2016
is this the default behaviour ... or are we testing it for a whiltelist of users ? Does "on user activity" indicate all trackpad, touchpad and keyboard ?
,
May 12 2016
It's the default behavior (there's currently no mechanism to allow running experiments outside of Chrome). "User activity" is touchpad, touchscreen, and keyboard input.
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31 2016
,
Feb 17 2017
,
Mar 18 2017
Activating. Please assign to the right owner and the appropriate priority.
,
Apr 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 13 2018
Think we still need to address Dan's comments in #4. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mshe...@chromium.org
, Apr 20 2016