New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604955 link

Starred by 0 users
Status: Fixed
Owner:
█ jessi...@chromium.org
Email to this user bounced
Closed: Apr 2016
Cc:
█ jessi...@chromium.org
kmarshall@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor BlimpPrefStore and AwPrefStore for cleaner reuse

Reported by jessi...@chromium.org, Apr 20 2016 
BlimpPrefStore is derived from AwPrefStore. The two reuse many of the same implementations and the light-weight memory backed store implementation they share could be useful to others.

It would be best to pull the shared functionality into a tested base class each overrides based on their specific requirements.

Comment 1 by w...@chromium.org, Apr 22 2016

Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b891cd667f263782a6f97466e264de3e729d3bc0

commit b891cd667f263782a6f97466e264de3e729d3bc0
Author: jessicag <jessicag@chromium.org>
Date: Fri Apr 22 23:16:06 2016

Create a PrefStore in support of Blimp metrics collection.

A light-weight memory-backed perfstore implementation. Needed for MetricService support. Used to hold logs until upload.

Moving the existing store for android webview into a shared space under components/pref and adding tests.

BUG= 592757 , 604955 

Review URL: https://codereview.chromium.org/1881253003

Cr-Commit-Position: refs/heads/master@{#389291}

[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/BUILD.gn
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/android_webview.gyp
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/browser/aw_browser_context.cc
[delete] https://crrev.com/ff03713022563711d6ed3d5e15a43decfaf867f4/android_webview/browser/aw_pref_store.cc
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/BUILD.gn
[add] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/in_memory_pref_store.cc
[rename] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/in_memory_pref_store.h
[add] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/in_memory_pref_store_unittest.cc
[modify] https://crrev.com/b891cd667f263782a6f97466e264de3e729d3bc0/components/prefs/prefs.gyp

Comment 3 by jessi...@chromium.org, Apr 22 2016

Owner: jessi...@chromium.org
Status: Fixed (was: Available)

Comment 4 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment