Actual: 16px Expected: 24px For both basic and advanced sections
It looks like the mocks say the sizing should be [24px][icon][16px][label...][16px] Are you asking for it to be [24px][icon][24px][label...][16px]
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46c22835a225bc3c6361a45fa3558400eb7b5dd commit e46c22835a225bc3c6361a45fa3558400eb7b5dd Author: dschuyler <dschuyler@chromium.org> Date: Fri Apr 29 23:32:19 2016 [MD settings] side nav routing to page sections This CL makes the side nav show the correct settings section when selecting a page in the menu. Several routes have been added for top-level pages (non-subpages). A SettingsRoute closure type has been defined. BUG= 604942 , 593989 , 584478 , 606632 Review-Url: https://codereview.chromium.org/1916323002 Cr-Commit-Position: refs/heads/master@{#390802} [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/advanced_page.html [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/advanced_page.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/browser/resources/settings/settings_page/settings_router.js [modify] https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd/chrome/test/data/webui/settings/people_page_test.js
Comment 1 by dschuyler@chromium.org
, Apr 20 201618.5 KB
18.5 KB View Download