New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604935 link

Starred by 1 user
Status: Fixed
Owner:
█ markdittmer@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
█ vollick@chromium.org
█ bsalomon@chromium.org
█ fsam...@chromium.org
rjkroege@chromium.org
sadrul@chromium.org
piman@chromium.org
dpranke@chromium.org
ccameron@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
mus

Blocked on:
issue 608805


Sign in to add a comment

Test coverage dropped by r386084

Project Member Reported by ccameron@chromium.org, Apr 19 2016 
At r386084 (https://codereview.chromium.org/1845563005), we moved a bunch of code from content/common/gpu to gpu/ipc/services.

This involved moving some tests out of content_unittests into gpu_ipc_unittests.

But we don't run gpu_ipc_unittests anywhere. I only noticed this when I moved parts of gpu_ipc_unittests to accelerated_widget_mac_unittests. To verify this, I added EXPECT_TRUE(false) in https://codereview.chromium.org/1894263004, and it's all green.

Adding all of the reviewers who missed this (myself included).

Comment 1 by fsam...@chromium.org, Apr 20 2016

Labels: -Pri-3 mustash mus gpurefactor OS-All Pri-1
Marking as P1. I think this is really important to make sure we don't regress as we make changes.

Comment 2 by fsam...@chromium.org, Apr 20 2016 

Dumb question: How do you get a new test binary to run on bots?

Comment 3 by dpranke@chromium.org, Apr 20 2016 

Not actually a dumb question, since I don't know that this is documented anywhere.

For most of the chromium bots, figure out which waterfall bots you want the test to run on, and add entries for it to the corresponding //testing/buildbot/*.json files.

The trybots that match each corresponding waterfall bot will pick up the tests automatically.

Comment 4 by ccameron@chromium.org, Apr 20 2016 

Agree not a dumb question -- my secret motivation for filing this bug was to get instructions for how to do it for ui/accelerated_widget_mac.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b49a88516b4ac62c00541144f2519e1737316d0

commit 4b49a88516b4ac62c00541144f2519e1737316d0
Author: markdittmer <markdittmer@chromium.org>
Date: Wed Apr 27 20:26:49 2016

Fix gpu_ipc_service_unittests on mac_chromium_rel_ng by managing GL shared groups the same way in stub-case as in real-case.

BUG= 604935 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1930633002
Cr-Commit-Position: refs/heads/master@{#390166}

[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/gpu/ipc/service/gpu_command_buffer_stub.cc
[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/ui/gl/gl_context_android.cc
[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/ui/gl/gl_context_mac.mm
[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/ui/gl/gl_context_ozone.cc
[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/ui/gl/gl_context_stub.cc
[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/ui/gl/gl_context_stub.h
[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/ui/gl/gl_context_win.cc
[modify] https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0/ui/gl/gl_context_x11.cc

Comment 6 by markdittmer@chromium.org, May 3 2016

Blockedon: 608805

Comment 7 by fsam...@chromium.org, May 4 2016

Cc: vollick@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/753fb9df926342654794f7e2c87fcdc7bc0b7fdc

commit 753fb9df926342654794f7e2c87fcdc7bc0b7fdc
Author: markdittmer <markdittmer@chromium.org>
Date: Thu May 05 13:46:06 2016

Fix gpu_ipc_service_unittests on android release gn builds

BUG= 604935 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1950093002
Cr-Commit-Position: refs/heads/master@{#391794}

[modify] https://crrev.com/753fb9df926342654794f7e2c87fcdc7bc0b7fdc/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/753fb9df926342654794f7e2c87fcdc7bc0b7fdc/gpu/ipc/service/gpu_channel_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ce53ac21030beccd430af5e7c9fd7dec3cf761e

commit 2ce53ac21030beccd430af5e7c9fd7dec3cf761e
Author: markdittmer <markdittmer@chromium.org>
Date: Thu May 05 16:21:02 2016

Add gpu_ipc_service_unittests to buildbot configs

BUG= 604935 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1908013002
Cr-Commit-Position: refs/heads/master@{#391820}

[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/gpu/gpu.gyp
[add] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/gpu/gpu_ipc_service_unittests.isolate
[add] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/gpu/gpu_ipc_service_unittests_apk.isolate
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.android.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.memory.fyi.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium.win.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium_memory_trybot.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/chromium_trybot.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/client.v8.fyi.json
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e/testing/buildbot/tryserver.v8.json

Comment 10 by markdittmer@chromium.org, May 9 2016

Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a75c88d82c63ab8109e5e0907e653bbb5ba0a6a6

commit a75c88d82c63ab8109e5e0907e653bbb5ba0a6a6
Author: jbudorick <jbudorick@chromium.org>
Date: Mon May 09 14:43:02 2016

[Android] Set isolate targets for two gpu suites on chromium.android.

https://crrev.com/2ce53ac21030beccd430af5e7c9fd7dec3cf761e broke Android
Swarm Builder on chromium.android.

BUG= 604935 
TBR=dpranke@chromium.org,markdittmer@chromium.org

Review-Url: https://codereview.chromium.org/1957323002
Cr-Commit-Position: refs/heads/master@{#392314}

[modify] https://crrev.com/a75c88d82c63ab8109e5e0907e653bbb5ba0a6a6/testing/buildbot/chromium.android.json
►

Sign in to add a comment