New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604906 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

AudioManagerTest.GetAssociatedOutputDeviceID failing flakily on chromium.gpu.fyi waterfall

Project Member Reported by kbr@chromium.org, Apr 19 2016

Issue description

Example failing builds:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/21721
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/21719
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/21718

Failure log:

AudioManagerTest.GetAssociatedOutputDeviceID (run #1):
[ RUN      ] AudioManagerTest.GetAssociatedOutputDeviceID
[268:1472:0419/125459:1054062:ERROR:audio_manager_win.cc(329)] NOT IMPLEMENTEDGetAssociatedOutputDeviceID is not supported on this OS
[268:1472:0419/125459:1054062:ERROR:audio_manager_win.cc(329)] NOT IMPLEMENTEDGetAssociatedOutputDeviceID is not supported on this OS
e:uild\slave\gpu_win_builderuild\src\mediaudioudio_manager_unittest.cc(427): error: Value of: found_an_associated_device
  Actual: false
Expected: true
[  FAILED  ] AudioManagerTest.GetAssociatedOutputDeviceID (0 ms)

This just started failing and is part of the reason the bots are red. Could you please figure out why? Thanks.

 

Comment 1 by w...@chromium.org, Apr 19 2016

Owner: alokp@chromium.org
alokp@: I noticed that this started failing when your CL landed. Seems likely to be related. Could you take a look?

Comment 3 by alokp@chromium.org, Apr 19 2016

Status: Started (was: Assigned)

Comment 4 by alokp@chromium.org, Apr 19 2016

I do not have a windows machine but have sent a speculative fix to CQ:
https://codereview.chromium.org/1897383003/
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4269ee621e1022bffeeea6cf5ce80f7502c3808

commit f4269ee621e1022bffeeea6cf5ce80f7502c3808
Author: alokp <alokp@chromium.org>
Date: Wed Apr 20 00:37:36 2016

Use AudioManager::CreateForTesting for unittests.

This is a speculative fix for
AudioManagerTest.GetAssociatedOutputDeviceId where it is failing
to create core audio device enumerator presumably because COM is
not initialized on the audio thread.

BUG= 604906 
TBR=tommi,dalecurtis

Review URL: https://codereview.chromium.org/1897383003

Cr-Commit-Position: refs/heads/master@{#388379}

[modify] https://crrev.com/f4269ee621e1022bffeeea6cf5ce80f7502c3808/media/audio/audio_manager_unittest.cc

Comment 6 by alokp@chromium.org, Apr 20 2016

Status: Fixed (was: Started)
Seems like the fix worked.

Comment 7 by kbr@chromium.org, Apr 20 2016

Thanks Alok.

Sign in to add a comment