Code base vs Wundefined-var-template |
||
Issue descriptionupstream clang r266719 added a new warning. Chrome doesn't build with it. I've seen problems in ANGLE and v8 that look probably fixable, and in web_contents_user_data.h (https://code.google.com/p/chromium/codesearch#chromium/src/content/public/browser/web_contents_user_data.h&q=web_contents_user_data.h&sq=package:chromium&type=cs&l=5) which probably aren't -- note the weird macro. I'm not a fan of that class (bug 589840), but for now we have to live with it. Step one is disabling the warning to unbreak the tot bots, I suppose. After that, check what it takes to build with the warning on and if that makes sense. (And if not, study if it makes sense to have the warning on by default upstream.) (my angle diff: diff --git a/src/libANGLE/queryconversions.h b/src/libANGLE/queryconversions.h index e0fdbe1..d971046 100644 --- a/src/libANGLE/queryconversions.h +++ b/src/libANGLE/queryconversions.h @@ -25,6 +25,12 @@ struct GLTypeToGLenum { static GLenum value; }; +template<> GLenum GLTypeToGLenum<GLint>::value; +template<> GLenum GLTypeToGLenum<GLuint>::value; +template<> GLenum GLTypeToGLenum<GLboolean>::value; +template<> GLenum GLTypeToGLenum<GLint64>::value; +template<> GLenum GLTypeToGLenum<GLfloat>::value; + // The GL state query API types are: bool, int, uint, float, int64 template <typename QueryT> ) I'll disable the warning; other than that assigning to current tot sheriff (who's sick today).
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4e7c5c697e2d59d897a7bbedc77a33d798df85b commit d4e7c5c697e2d59d897a7bbedc77a33d798df85b Author: thakis <thakis@chromium.org> Date: Tue Apr 19 23:52:04 2016 Disable -Wundefined-var-template on the clang tot bots. It's a new warning upstream and it fires in several places in Chromium. Suppress this for now to get the clang tot bots back green. BUG=604888 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/1902263003 Cr-Commit-Position: refs/heads/master@{#388364} [modify] https://crrev.com/d4e7c5c697e2d59d897a7bbedc77a33d798df85b/build/common.gypi [modify] https://crrev.com/d4e7c5c697e2d59d897a7bbedc77a33d798df85b/build/config/compiler/BUILD.gn
,
Apr 27 2016
lots of warnings are printed out [129/19314] CXX clang_x64/obj/base/base/task_runner.o warning: unknown warning option '-Wno-undefined-var-template'; did you mean '-Wno-undefined-internal'? [-Wunknown-warning-option] 1 warning generated.
,
Apr 27 2016
dongseong.hwang: Where are these warnings being printed? Is this on a buildbot somewhere? If it's in a local build, how is it configured?
,
May 4 2016
A simple build of V8 with a fairly recent clang fails with the warning in #3. Looking at clang: git blame include/clang/Basic/DiagnosticGroups.td|grep undefined-var-template e7d59be7 (Serge Pavlov 2016-04-19 06:19:52 +0000 84) def UndefinedVarTemplate : DiagGroup<"undefined-var-template">; This is pretty bleeding edge! The clang commit for this was r266719 and the current chromium clang is based on r268373 (so: recently supported). It would be nice to feature detect that warning, or since it's temporary bundle it with -Wno-unknown-warning-option.
,
May 5 2016
We only support building chrome (etc like v8) with the pinned clang, which is rolled at the same time as we change warning flags. Which clang are you using and why does it not support that flag?
,
Aug 1
|
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Apr 19 2016