Issue metadata
Sign in to add a comment
|
Bookmarks bar is transparent if you drag a New Tab off a primary-monitor window to a window on secondary monitor |
||||||||||||||||||||||
Issue descriptionVersion: 51.0.2704.0 dev OS: ChromeOS What steps will reproduce the problem? (1) Configure a system with two monitors. Mine has secondary to left of primary. (2) Open a window on primary monitor, and open several tabs in it. (3) Open a New Tab in that window. (4) Drag that New Tab out of the window, across to the secondary monitor. Observe that the bookmarks area of the window is transparent once it reaches the secondary monitor.
,
Apr 19 2016
Painting problem? You can take a trace to see what the recording looks like: https://www.chromium.org/developers/how-tos/trace-event-profiling-tool/frame-viewer
,
May 13 2016
,
May 13 2016
I had a fix, which was buried in other changes. I just need to resurrect it.
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25 commit e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25 Author: oshima <oshima@chromium.org> Date: Fri May 20 04:08:16 2016 Create a LayerDelegate for recreated layers to draw when their content is invalidated. This is to mitigate the issue where the content of the layer has to be redrawn while dragging a window in another display. This can draw the display items recorded for different device scale factor which can have artifacts, but it's better than empty layer. The same issue can happen during hiding/showing animation in theory, but I'm leaving them as is because that's very rare and most likely not noticeable. BUG= 604868 TEST=WindowUtilTest.RecreateLayersWithDelegate TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/1992853002 Cr-Commit-Position: refs/heads/master@{#394993} [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ash/rotator/screen_rotation_animator.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ash/wm/aura/wm_window_aura.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ash/wm/drag_window_controller.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ash/wm/drag_window_controller.h [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/chrome/browser/ui/views/frame/contents_web_view.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ui/views/view_unittest_aura.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ui/wm/core/window_animations.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ui/wm/core/window_util.cc [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ui/wm/core/window_util.h [modify] https://crrev.com/e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25/ui/wm/core/window_util_unittest.cc
,
May 20 2016
,
May 21 2016
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
,
May 26 2016
,
May 26 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c81fdc9edfb72dd0826075e2f77478f53577aea8 commit c81fdc9edfb72dd0826075e2f77478f53577aea8 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri May 27 00:18:45 2016 Create a LayerDelegate for recreated layers to draw when their content is invalidated. This is to mitigate the issue where the content of the layer has to be redrawn while dragging a window in another display. This can draw the display items recorded for different device scale factor which can have artifacts, but it's better than empty layer. The same issue can happen during hiding/showing animation in theory, but I'm leaving them as is because that's very rare and most likely not noticeable. BUG= 604868 TEST=WindowUtilTest.RecreateLayersWithDelegate TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/1992853002 Cr-Commit-Position: refs/heads/master@{#394993} (cherry picked from commit e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25) Review URL: https://codereview.chromium.org/2020493002 . Cr-Commit-Position: refs/branch-heads/2743@{#95} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ash/rotator/screen_rotation_animator.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ash/wm/aura/wm_window_aura.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ash/wm/drag_window_controller.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ash/wm/drag_window_controller.h [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/chrome/browser/ui/views/frame/contents_web_view.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ui/views/view_unittest_aura.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ui/wm/core/window_animations.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ui/wm/core/window_util.cc [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ui/wm/core/window_util.h [modify] https://crrev.com/c81fdc9edfb72dd0826075e2f77478f53577aea8/ui/wm/core/window_util_unittest.cc
,
May 27 2016
We should probably punt this to R52, we are too close to stable if this is not a blocker.
,
May 27 2016
,
May 27 2016
,
Jun 21 2016
Verified on M52 beta (8350.37.0, 52.0.2743.46) and TOT (8481.0.0, 53.0.2773.0) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Apr 19 201619.7 KB
19.7 KB View Download