Issue 604861 link

Starred by 1 user

Issue metadata

Status:	Started
Owner:	█ nednguyen@chromium.org Last visit > 30 days ago
Cc:	█ aiolos@chromium.org
Components:	Test>Telemetry
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-Google

Remove the construction of telemetry.page.action_runner.ActionRunner and access action_runner from tab object directly

Project Member Reported by nedngu...@google.com, Apr 19 2016

Issue description

action_runner is now a member of tab object: https://codereview.chromium.org/1857173002/

However, there are multiple places in chromium/src that are still constructing the action_runner.ActionRunner object from tab: https://code.google.com/p/chromium/codesearch#search/&q=action_runner.ActionRunner&sq=package:chromium&type=cs

All these places should be changed to access tab.action_runner directly.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095bc6d6946dff2a63c1e6f1bc00df141accbac1

commit 095bc6d6946dff2a63c1e6f1bc00df141accbac1
Author: nednguyen <nednguyen@google.com>
Date: Wed Apr 20 02:41:11 2016

[tools/perf] Update users of action_runner to directly referencing it from tab.action_runner field

BUG=604861
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1896113003

Cr-Commit-Position: refs/heads/master@{#388408}

[modify] https://crrev.com/095bc6d6946dff2a63c1e6f1bc00df141accbac1/tools/perf/benchmarks/service_worker.py
[modify] https://crrev.com/095bc6d6946dff2a63c1e6f1bc00df141accbac1/tools/perf/measurements/blink_style.py
[modify] https://crrev.com/095bc6d6946dff2a63c1e6f1bc00df141accbac1/tools/perf/measurements/oilpan_gc_times.py
[modify] https://crrev.com/095bc6d6946dff2a63c1e6f1bc00df141accbac1/tools/perf/measurements/timeline_controller.py