[Tab capture] "Tab capturing" feature is available on some chrome devices by default |
|||||
Issue descriptionChrome Version: 51.0.2704.15 / 8172.4.0 dev Device: Link/Pixel What steps will reproduce the problem? 0. On the chrome device, browse to https://test.webrtc.org/manual/peer2peer/ 1. Click 'Screen capture' and if you get an error, follow the instructions and install the extension. If extension is already installed and there are no other errors, skip step 2. 2. After installing the extension, reload the page "https://test.webrtc.org/manual/peer2peer/" and click on 'Screen capture' 3. Observe the options listed under available windows for screen capturing Expected result: Screensharing Extension dialog box should display all available windows for screen capturing Actual result: Screensharing Extension dialog box is displaying all available windows and tabs for screen capturing. 'Tab capturing' feature should not be available for M51 (Reference bug: https://bugs.chromium.org/p/chromium/issues/detail?id=557222) Note: 1. This issue is so far seen on some of the chrome devices: https://docs.google.com/a/google.com/spreadsheets/d/1ctNPX85x__SlFyHTVkzmL07cA0BJuDnvrdbqyA7GRjI/edit?usp=sharing (More devices will be added to the sheet as and when they are tested) 2. "Tab capturing" is available through "Windows picker extension" by default in some of the devices. No flag state was changed in chrome://flags and no other extensions were installed on the device 3. Please confirm if tab capturing feature should be available only through "Desktop capture extension" and not via "Screensharing extension/ windows picker" extension
,
Apr 19 2016
For dev and beta version of chrome, it should be default on for tab capture.
,
Apr 19 2016
gyzhou@: Tab capture is available by default on only some of the chrome devices in M51 dev by default via windows picker extension. Is that expected and why ?
,
Apr 19 2016
It should be on for all chrome book if chrome is Dev version. Qiang is the author of this part of code.
,
Apr 19 2016
Several things to make sure: 1. The chrome version and build channel. If the build channel is stable or if the version is <=50, then it is default off. 2. The status of flag "Desktop Share with tab source". If the status is "Disable" then you cannot see tabs when doing capturing.
,
Apr 19 2016
qiang@: 1. This issue is seen on some chrome devices with M51 dev channel by default in screensharing extension (and not desktop capture extension) in https://test.webrtc.org/manual/peer2peer/ page 2. The status of flag "Desktop Share with tab source" is "Default" by default on some chrome devices. "Tab capturing" is not observed if the status is changed to "Disabled" Questions: 1. Why is the status of flag "Desktop Share with tab source" set to "Default" on some devices and "Disabled" on other devices (I did not change state of the flags before the tests) 2.Is Tab capturing expected to show up with Windows picker extension along with desktop capture extension ?
,
Apr 19 2016
1. The initial setting of flags is related to build process, and out of my scope. 2. Tab is expected to show up if either of the following is true: a. the flag is "Enabled" b. the flag is "Default" and it is a non-Stable build
,
Apr 19 2016
Thanks qiangchen@ 1. The initial setting of flags is related to build process, and out of my scope. -- tnakamura@ : As this issue seems to be related to chrome builds or chrome device specific, can you please reassign this bug appropriately ? 2. Is Tab capturing expected to show up with Windows picker extension along with desktop capture extension ? -- qiangchen@ confirmed offline that this it is expected for tab capturing to be available via windows picker extension.
,
Apr 19 2016
,
Apr 22 2016
Follow up request for srcv@ - on the machines where tab capture isn't available, can you download the latest github extension associated with the peer2peer page and see if tab capture is available? If so, I think you can close this as wontfix per comment #7 (and the offline chat we had with qiangchen@ earlier this week).
,
Apr 23 2016
Downloaded latest github extension associated with peer2peer page and observed that tab capturing is available by default on devices Peppy and Paine( where tab capturing wasn't available before by default) with M51 dev |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by srcv@chromium.org
, Apr 19 2016