New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604849 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Away
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Old Bottom Bar API in CCT is not working in M51

Project Member Reported by ian...@chromium.org, Apr 19 2016

Issue description

See attached screenshot.
 
1461094149.png
80.3 KB View Download

Comment 2 by ian...@chromium.org, Apr 20 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, Apr 20 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48

commit 6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48
Author: Ian Wen <ianwen@google.com>
Date: Thu Apr 21 21:41:03 2016

[Custom Tabs]Unbreak buttons on bottom bar

After thre refactoring related to remoteviews based bottom bar, the old
API stopped working. This CL fixes the breakage.

BUG= 604849 

Review URL: https://codereview.chromium.org/1895813004

Cr-Commit-Position: refs/heads/master@{#388559}
TBR=yusufo@chromium.org

Review URL: https://codereview.chromium.org/1908173002 .

Cr-Commit-Position: refs/branch-heads/2704@{#173}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48/chrome/android/java/res/values/ids.xml
[modify] https://crrev.com/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java
[modify] https://crrev.com/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Comment 5 by ian...@chromium.org, Apr 21 2016

Status: Fixed (was: Assigned)
Fixed in M51.

Comment 6 by oprater@google.com, Apr 28 2016

I'm seeing this issue in the new Chrome Beta version 51.0.2704.28. 

Comment 7 by oprater@google.com, Apr 28 2016

I'm seeing this issue in the new Chrome Beta version 51.0.2704.28. Only on N. Works fine for me on M.

Comment 8 by oprater@google.com, Apr 29 2016

Updated N to NRD27C and I no longer see this. Thanks. 

Sign in to add a comment