Old Bottom Bar API in CCT is not working in M51 |
|||||
Issue descriptionSee attached screenshot.
,
Apr 20 2016
,
Apr 20 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48 commit 6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48 Author: Ian Wen <ianwen@google.com> Date: Thu Apr 21 21:41:03 2016 [Custom Tabs]Unbreak buttons on bottom bar After thre refactoring related to remoteviews based bottom bar, the old API stopped working. This CL fixes the breakage. BUG= 604849 Review URL: https://codereview.chromium.org/1895813004 Cr-Commit-Position: refs/heads/master@{#388559} TBR=yusufo@chromium.org Review URL: https://codereview.chromium.org/1908173002 . Cr-Commit-Position: refs/branch-heads/2704@{#173} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java [modify] https://crrev.com/6e1eac4cfd970cf00c4ff28fcd9f7877584cdd48/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
,
Apr 21 2016
Fixed in M51.
,
Apr 28 2016
I'm seeing this issue in the new Chrome Beta version 51.0.2704.28.
,
Apr 28 2016
I'm seeing this issue in the new Chrome Beta version 51.0.2704.28. Only on N. Works fine for me on M.
,
Apr 29 2016
Updated N to NRD27C and I no longer see this. Thanks. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 20 2016