New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604847 link

Starred by 2 users
Status: Fixed
Owner:
sa...@chromium.org
Closed: Dec 2016
Cc:
amistry@chromium.org
jam@chromium.org
█ most...@opera.com
brucedaw...@chromium.org
█ roc...@chromium.org
█ yzshen@chromium.org
msw@chromium.org
█ e...@chromium.org
wfh@chromium.org
sky@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 606012
issue 606013


Sign in to add a comment

Most mojo-related tests are not run through Swarming

Project Member Reported by st...@chromium.org, Apr 19 2016 
Below is the list of mojo tests that are not run through Swarming yet.
If they are run on Swarming and test failures occur, Findit will be able to deflake by Swarming rerun and then trigger try-jobs to identify the culprits automatically.

mojo_apptests
ipc_mojo_unittests
mojo_js_integration_tests
mojo_js_unittests
mojo_public_application_unittests
mojo_runner_host_unittests
mojo_shell_unittests
mojo_surfaces_lib_unittests
mojo_system_unittests
mojo_view_manager_lib_unittests

Comment 1 by jam@chromium.org, Apr 19 2016

Cc: roc...@chromium.org sa...@chromium.org yzshen@chromium.org amistry@chromium.org
Components: Internals>Mojo
Labels: -Pri-3 Pri-2
+a few folks

Comment 2 by jam@google.com, Apr 22 2016

Cc: e...@chromium.org gl...@skynav.com
from https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/217525

filesystem_service_unittests  took 7 minutes
mash_unittests  took 5 minutes

and the rest all under 10 s. I agree all should be swarmed, but let's do the slow ones first.

Comment 3 by jam@google.com, Apr 22 2016

Blockedon: 606012

Comment 4 by jam@google.com, Apr 22 2016

Blockedon: 606013

Comment 5 by jam@google.com, Apr 22 2016

Cc: -gl...@skynav.com sky@chromium.org

Comment 6 by sa...@chromium.org, Apr 26 2016

Cc: -sa...@chromium.org
Owner: sa...@chromium.org
Status: Assigned (was: Available)
It looks like filesystem_service_unittests and mash_unittests are normally quick, but sometimes wait several minutes before timing out.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ecd4a58d5b625759b2121be8254cd1abec8dc7

commit 98ecd4a58d5b625759b2121be8254cd1abec8dc7
Author: sammc <sammc@chromium.org>
Date: Fri Apr 29 01:59:21 2016

Convert Mojo tests to use swarming.

BUG= 604847 

Review-Url: https://codereview.chromium.org/1918143004
Cr-Commit-Position: refs/heads/master@{#390573}

[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/BUILD.gn
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/gin/BUILD.gn
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/ipc/mojo/ipc_mojo.gyp
[add] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/ipc/mojo/ipc_mojo_unittests.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/edk/js/test/BUILD.gn
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/edk/js/tests/BUILD.gn
[add] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo_common_unittests.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo_edk_tests.gyp
[add] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo_js_integration_tests.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo_js_unittests.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo_public_bindings_unittests.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo_public_system_unittests.isolate
[add] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/mojo_system_unittests.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/public/js/BUILD.gn
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/public/mojo_application_manifest.gni
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/mojo/tools/apptest_runner.py
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/services/catalog/BUILD.gn
[add] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/services/shell/mojo_shell_unittests.isolate
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/services/shell/shell.gyp
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/services/shell/tests/connect/BUILD.gn
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/services/shell/tests/lifecycle/BUILD.gn
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/testing/buildbot/chromium.memory.fyi.json
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/testing/buildbot/chromium.win.json
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7/testing/test.gni

Comment 8 by most...@opera.com, Apr 29 2016

Cc: most...@opera.com
Proposed dependency fixup here: https://codereview.chromium.org/1930773006/
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94d9e148d47990c72a76ce0cb8602d55418fea5e

commit 94d9e148d47990c72a76ce0cb8602d55418fea5e
Author: mostynb <mostynb@opera.com>
Date: Fri Apr 29 09:29:12 2016

fix ipc_mojo_unittests.isolate dependencies

BUG= 604847 

Review-Url: https://codereview.chromium.org/1930773006
Cr-Commit-Position: refs/heads/master@{#390606}

[modify] https://crrev.com/94d9e148d47990c72a76ce0cb8602d55418fea5e/ipc/mojo/ipc_mojo_unittests.isolate
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d20aaaab890829087e0870d8116b720685b43a7

commit 3d20aaaab890829087e0870d8116b720685b43a7
Author: Nico Weber <thakis@chromium.org>
Date: Fri Apr 29 16:19:11 2016

Try to unbreak gyp build-only bots after https://codereview.chromium.org/1918143004/

isolate_tests is failing 'cause the _run target for the newly isolated
test didn't get build.

BUG= 604847 
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1935553002 .

Cr-Commit-Position: refs/heads/master@{#390665}

[modify] https://crrev.com/3d20aaaab890829087e0870d8116b720685b43a7/build/gn_migration.gypi
Project Member

Comment 11 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/240148a6d2a5a10a7a3c1cb5b91a42e4ddfcff8c

commit 240148a6d2a5a10a7a3c1cb5b91a42e4ddfcff8c
Author: sammc <sammc@chromium.org>
Date: Mon May 09 01:52:46 2016

Swarm mojo tests on Win8 too.

BUG= 604847 

Review-Url: https://codereview.chromium.org/1944313005
Cr-Commit-Position: refs/heads/master@{#392282}

[modify] https://crrev.com/240148a6d2a5a10a7a3c1cb5b91a42e4ddfcff8c/testing/buildbot/chromium.win.json

Comment 13 by sa...@chromium.org, Jun 8 2016

Cc: brucedaw...@chromium.org msw@chromium.org wfh@chromium.org
 Issue 598457  has been merged into this issue.

Comment 14 by sa...@chromium.org, Dec 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment