New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604833 link

Starred by 3 users
Status: Fixed
Owner:
l...@chromium.org
Closed: May 2016
Cc:
█ lushnikov@chromium.org
maxwalker@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Drawer Panels style update

Project Member Reported by l...@chromium.org, Apr 19 2016 
Some style changes affecting the drawer panels need updating.

There are some slides showing new designs here:
https://docs.google.com/a/google.com/presentation/d/1mmGYr6pqwEC74qudxUkdvKfpC3T4FupNIfz-G6hIx7I/edit?usp=sharing

Comment 1 by l...@chromium.org, Apr 19 2016

Status: Started (was: Assigned)

Comment 2 by pfeldman@chromium.org, Apr 19 2016

Labels: Restrict-View-Google

Comment 3 by pfeldman@chromium.org, Apr 19 2016

Labels: -Restrict-View-Google

Comment 4 by l...@chromium.org, Apr 19 2016

Cc: -maxwalker@chromium.org -paulir...@chromium.org -pfeldman@chromium.org lushnikov@chromium.org
Screenshots of UI
rendering.png
30.5 KB View Download
netcon.png
23.2 KB View Download
search.png
12.6 KB View Download
sensors.png
24.9 KB View Download

Comment 7 by l...@chromium.org, Apr 25 2016 

Other needed UI updates:
- User agent field in Network Conditions panel should always be editable.  Read-only fields make it hard to quickly edit a section of a preset user agent.

Comment 8 by maxwalker@chromium.org, Apr 26 2016 

I was thinking that it's editable and would select "Custom" as soon as it doesn't match one of the presets anymore. Sounds good?

Comment 9 by l...@chromium.org, Apr 26 2016

Cc: maxwalker@chromium.org
An always editable input field is what I imagined also, but I changed it after a discussion with Lushnikov.

We were concerned that users might think that selecting a preset and editing it might indicate that they were editing the saved preset value.  By allowing double click to edit, it would be clear that the preset value is read only.

I'm not a UI expert, is this a non-issue?  If so, it's a quick fix.

Comment 10 by lushnikov@chromium.org, Apr 26 2016 

The double-click behavior feels good!

Comment 11 by maxwalker@chromium.org, Apr 27 2016 

I think switching from the selected preset to "Custom" once a user edits the UA string is sufficient feedback to explain that we are not overwriting a saved preset. Double-clicking a text field is not common and non-standard behavior so I think we shouldn't do that.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ce96ed769ae4aa03ec68d23f92e9f1b3441c2ba

commit 0ce96ed769ae4aa03ec68d23f92e9f1b3441c2ba
Author: luoe <luoe@chromium.org>
Date: Wed Apr 27 18:12:19 2016

DevTools: Switching to custom user agent no longer clears preexisting value

BUG= 604833 

Review-Url: https://codereview.chromium.org/1918613002
Cr-Commit-Position: refs/heads/master@{#390128}

[modify] https://crrev.com/0ce96ed769ae4aa03ec68d23f92e9f1b3441c2ba/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de496bd9eb61224a98706299f73b1898a3a210c0

commit de496bd9eb61224a98706299f73b1898a3a210c0
Author: luoe <luoe@chromium.org>
Date: Wed Apr 27 20:52:28 2016

DevTools: Update styles for full text search drawer panel

BUG= 604833 

Review-Url: https://codereview.chromium.org/1902283002
Cr-Commit-Position: refs/heads/master@{#390177}

[modify] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[add] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/Images/src/search.svg
[modify] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[modify] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg
[modify] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs.png
[modify] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png
[modify] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js
[modify] https://crrev.com/de496bd9eb61224a98706299f73b1898a3a210c0/third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2df4390a4c22bf018a63e575a66aa210405835d

commit c2df4390a4c22bf018a63e575a66aa210405835d
Author: luoe <luoe@chromium.org>
Date: Wed Apr 27 21:10:17 2016

DevTools: update list of preset user agents

BUG= 604833 

Review-Url: https://codereview.chromium.org/1923513003
Cr-Commit-Position: refs/heads/master@{#390186}

[modify] https://crrev.com/c2df4390a4c22bf018a63e575a66aa210405835d/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

Comment 16 by l...@chromium.org, May 2 2016 

Screenshot for new 3D phone model:
http://imgur.com/PLR6qac
Project Member

Comment 18 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb

commit 2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb
Author: luoe <luoe@chromium.org>
Date: Thu May 05 19:02:28 2016

DevTools: Update 3D device in accelerometer emulation

BUG= 604833 

Review-Url: https://codereview.chromium.org/1923843003
Cr-Commit-Position: refs/heads/master@{#391863}

[modify] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/devtools.gypi
[add] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/Images/accelerometer-back.png
[add] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/Images/accelerometer-bottom.png
[add] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/Images/accelerometer-front.png
[add] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/Images/accelerometer-left.png
[add] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/Images/accelerometer-right.png
[add] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/Images/accelerometer-top.png
[modify] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
[modify] https://crrev.com/2543cd77d5ecb9f37fa0b59b4c1bf2e6b3a7d0fb/third_party/WebKit/Source/devtools/front_end/emulation/sensors.css

Comment 19 by l...@chromium.org, May 6 2016

Status: Fixed (was: Started)

Comment 20 by l...@chromium.org, May 6 2016

Status: Started (was: Fixed)
Some properties including linear-gradient and transform should have the webkit prefix removed.

Comment 21 by l...@chromium.org, May 6 2016

Cc: phistuck@chromium.org

Comment 22 by phistuck@chromium.org, May 6 2016

Cc: -phistuck@chromium.org

Comment 23 by l...@chromium.org, May 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment