New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604829 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 598390

Blocking:
issue 402656



Sign in to add a comment

Devtools: Make JSON View Searchable

Project Member Reported by allada@chromium.org, Apr 19 2016

Issue description

WebInspector.JSONView should implement WebInspector.Searchable interface and allow it to be searchable in preview under network panel.
 

Comment 1 by allada@chromium.org, Apr 22 2016

Blocking: 402656

Comment 2 by allada@chromium.org, Apr 22 2016

Components: Platform>DevTools>Network

Comment 3 by allada@chromium.org, Apr 22 2016

Blockedon: 598390
Summary: Devtools: Make JSON View Searchable (was: Devtools: Make JSONView Searchable)
Cc: allada@chromium.org paulir...@chromium.org
 Issue 609132  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b759d6d6898f784a912b11278039425fbad8415

commit 9b759d6d6898f784a912b11278039425fbad8415
Author: allada <allada@chromium.org>
Date: Fri May 06 22:01:26 2016

[Devtools] JSONView implements Searchable interface

WebInspector.JSONView now implements WebInspector.Searchable interface
and allows it to be searchable (with search bar) in network panel.

BUG= 604829 
R=lushnikov

Review-Url: https://codereview.chromium.org/1899893003
Cr-Commit-Position: refs/heads/master@{#392169}

[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview-expected.txt
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view-expected.txt
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html
[add] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/LayoutTests/http/tests/inspector/network/preview-searchable-expected.txt
[add] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/LayoutTests/http/tests/inspector/network/preview-searchable.html
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/Source/devtools/front_end/network/JSONView.js
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
[modify] https://crrev.com/9b759d6d6898f784a912b11278039425fbad8415/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Comment 7 by allada@chromium.org, May 19 2016

Status: Fixed (was: Started)

Sign in to add a comment