New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604814 link

Starred by 1 user
Status: Fixed
Owner:
█ chongz@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
█ aelias@chromium.org
dtapu...@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Ctrl+Enter should do nothing instead of inserting newline

Project Member Reported by chongz@chromium.org, Apr 19 2016 
Version: 49.0.2623.105
OS: Android 6.0.0

What steps will reproduce the problem?
(1) Navigate to 'data:text/html,<textarea>xy'
(2) Focus textarea and press Ctrl+Enter
(3) Observe caret

What is the expected output?
caret should not move (i.g. Ctrl+Enter should do nothing) 

What do you see instead?
caret moved to next line (i.g. inserted a newline)

On Chrome desktop and Firefox desktop/Android Ctrl+Enter won't insert newline.

Comment 1 by chongz@chromium.org, Apr 20 2016 

Internal issue b/28224354

Comment 2 by yutak@chromium.org, May 6 2016

Components: -Blink>Input Blink>Editing

Comment 3 by yutak@chromium.org, May 6 2016 

(I'm not sure what is the right behavior of Ctrl+Enter...)
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afecfc0cc941ff50487fd9f8010facbcaf67578e

commit afecfc0cc941ff50487fd9f8010facbcaf67578e
Author: chongz <chongz@chromium.org>
Date: Tue May 10 08:46:26 2016

Ctrl/Alt+Enter shouldn't insert newline

Before CL Ctrl/Alt+Enter will insert newline on Mac and Android, but
won't insert newline on Windows and Linux ( https://crbug.com/608447 ).

According to discussion Ctrl+Enter often gets used as shortcuts
in many apps such as sending emails on Gmail web, and it
shouldn't do the same thing as Enter.

Currently Safari will insert newline, Edge won't, Firefox won't insert
newline on all platforms. We match Firefox.

BUG= 604814 

Review-Url: https://codereview.chromium.org/1942683004
Cr-Commit-Position: refs/heads/master@{#392566}

[add] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/LayoutTests/editing/input/keyboard-ctrl-enter-no-newline.html
[modify] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/LayoutTests/editing/input/resources/reveal-utilities.js
[modify] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt
[modify] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
[modify] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
[modify] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/LayoutTests/editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html
[modify] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
[modify] https://crrev.com/afecfc0cc941ff50487fd9f8010facbcaf67578e/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

Comment 5 by chongz@chromium.org, May 10 2016

Labels: M-52 OS-Mac
Status: Fixed (was: Started)
►

Sign in to add a comment