New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604810 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 584266



Sign in to add a comment

Snippets: Make publishing date more readable

Project Member Reported by nepper@chromium.org, Apr 19 2016

Issue description

We should adopt Now's time duration pattern, which is more readable (and thus more accessible):

12 hours ago
1 day ago
 
We already have that. (See attached screenshot, this is on Chrome Dev)

Patrick, can you clarify?
device-2016-04-20-100653.png
730 KB View Download

Comment 2 by bauerb@chromium.org, Apr 20 2016

Owner: nepper@chromium.org
Never mind, figured out it's a localization issue. en-UK gives 12 hours ago while en-US gives 12 hr. ago

Comment 4 by peconn@chromium.org, Apr 20 2016

We have discovered that this could be a localisation issue. May's phone is set to UK English and give '6 hours ago', while mine is set to US English and gives '6 hr. ago'. Was this what you were talking about?


2016-04-20_11-08-28.png
321 KB View Download

Comment 5 by nepper@chromium.org, Apr 20 2016

Owner: ----
I think then the I18N issue is UK English ;)

Rachel's mocks contained the abbreviated version (which then made it into the US original string I guess), but we want to have the long version in all EN (and other languages), so:

hours/days ago, not hr.

Comment 6 by dgn@chromium.org, Apr 21 2016

Labels: zine-mr-iter-12
Owner: dgn@chromium.org
Status: Assigned (was: Available)
For some reason it's not stable across OS versions and Locales. on N6/M it says "x hr. ago" and on N5/KK is says "x hours ago", both en_GB.

An argument in favour of the short strings: It might be better when we have the publisher name in, as it's on the same line in the mocks. Abbreviated strings will look better on small screens.

Comment 7 by nepper@chromium.org, Apr 22 2016

That's weird, how can this be different across OS versions? Don't we (Chrome) own this string?

Comment 8 by treib@chromium.org, Apr 22 2016

+1 for "long" strings ("hours"). The "hr." abbreviation bugs me.

Comment 9 by bauerb@chromium.org, Apr 22 2016

Right now, we get the string from an Android API that could have changed.

Comment 10 by dgn@chromium.org, Apr 22 2016

No, we use a method from the android framework to format it: DateUtils.getRelativeTimeSpanString(..., DateUtils.FORMAT_ABBREV_RELATIVE)); 

That means that the format should be coherent across all apps that use the same format type on a given device. I can use the long format, but that was just to say that it may be a feature. I'll try to see where the change comes from.

Comment 11 by dgn@chromium.org, Apr 22 2016

I didn't find much, we delegate to icu4j, and I don't seem to see device or screen size specific code. It might be just related to library version differences. Anyway, I'm sending a CL to stop abbreviating.

Comment 12 by dgn@chromium.org, Apr 22 2016

Labels: -zine-mr-iter-12 zine-mr-iter-11
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0cae4edf5e0f84bf704d18ff9d634d2140c0b8b

commit d0cae4edf5e0f84bf704d18ff9d634d2140c0b8b
Author: dgn <dgn@chromium.org>
Date: Fri Apr 22 12:26:06 2016

[NTP Snippets] Express the snippet age with a non abbreviated string

Avoid using "1 hr. ago" or "3 mins ago" for example, and just uses
a long string.

BUG= 604810 

Review URL: https://codereview.chromium.org/1911243003

Cr-Commit-Position: refs/heads/master@{#389083}

[modify] https://crrev.com/d0cae4edf5e0f84bf704d18ff9d634d2140c0b8b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Comment 14 by dgn@chromium.org, Apr 22 2016

Status: Fixed (was: Started)

Comment 15 by fi...@chromium.org, Apr 22 2016

Blocking: 584266
Owner: maybelle@chromium.org
Status: Assigned (was: Fixed)
Accidentally regressed by crbug/596410. Fix up shortly.
Project Member

Comment 17 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9389d58add9c11a2b01db064d56f870db825d7d

commit b9389d58add9c11a2b01db064d56f870db825d7d
Author: maybelle <maybelle@chromium.org>
Date: Wed May 04 14:50:13 2016

Change snippets published date to long string

Regressed during a bad merge with the fix for 596410

BUG= 604810 

Review-Url: https://codereview.chromium.org/1949073002
Cr-Commit-Position: refs/heads/master@{#391507}

[modify] https://crrev.com/b9389d58add9c11a2b01db064d56f870db825d7d/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Status: Fixed (was: Assigned)
Labels: zine-mr-MVP

Comment 20 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp
Labels: zine-mr-MVP

Sign in to add a comment