New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604806 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: May 2016
Cc:
█ nick@chromium.org
msw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove the old task_manager_view.cc

Project Member Reported by afakhry@chromium.org, Apr 19 2016 
The old task manager view in task_manager_view.cc is no longer used except for starting the task manager when running the old task manager backend browser tests.

The flag is no longer necessary. The browser tests should only run on mac, which is still using the old backend in c/b/task_manager.

Comment 1 by afakhry@chromium.org, Apr 21 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17406972b0d3ab7d1448dda982dc294b6cede9a7

commit 17406972b0d3ab7d1448dda982dc294b6cede9a7
Author: afakhry <afakhry@chromium.org>
Date: Tue May 24 19:16:16 2016

Remove the old task manager view

This CL does the following:
- Enables the old task manager backend implementation only on MacOSX cocoa.
- Removes the --disable-new-task-manager flag.
- Removes the old task manager view

BUG= 604806 

Review-Url: https://codereview.chromium.org/1912773002
Cr-Commit-Position: refs/heads/master@{#395671}

[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/app/generated_resources.grd
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/BUILD.gn
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/about_flags.cc
[delete] https://crrev.com/64bbb2cf3aa33913002f90ee453c47029b0185f9/chrome/browser/caps/generate_state_json.cc
[delete] https://crrev.com/64bbb2cf3aa33913002f90ee453c47029b0185f9/chrome/browser/caps/generate_state_json.h
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_management/task_manager_browsertest.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_management/task_manager_interface.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_management/task_manager_interface.h
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_management/task_manager_tester.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_management/task_manager_tester.h
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_manager/legacy_task_manager_tester.cc
[delete] https://crrev.com/64bbb2cf3aa33913002f90ee453c47029b0185f9/chrome/browser/task_manager/legacy_task_manager_tester.h
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_manager/printing_information.h
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_manager/task_manager.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_manager/task_manager.h
[add] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/task_manager/task_manager_tester_nonmac.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/ui/browser.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/ui/cocoa/task_manager_mac.mm
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/browser/ui/views/new_task_manager_view.cc
[delete] https://crrev.com/64bbb2cf3aa33913002f90ee453c47029b0185f9/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/chrome_browser.gypi
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/chrome_tests.gypi
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/common/chrome_switches.cc
[modify] https://crrev.com/17406972b0d3ab7d1448dda982dc294b6cede9a7/chrome/common/chrome_switches.h

Comment 3 by afakhry@chromium.org, May 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment