New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604803 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Undefined-shift in WebRtcIlbcfix_DoThePlc

Project Member Reported by ClusterFuzz, Apr 19 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6325037115637760

Fuzzer: libfuzzer_audio_decoder_ilbc_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcIlbcfix_DoThePlc
  WebRtcIlbcfix_DecodeImpl
  WebRtcIlbcfix_Decode
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=386932:386961

Minimized Testcase (0.35 Kb): https://cluster-fuzz.appspot.com/download/AMIfv964OSj8AiZOd6oChNHeQhDG0UgPbUZSWPbP9hNi7X1S_DYgJVcrCkarnrGpnNbsOIAtd3YuadEROif3q0QrExsRLsFHQdEPVZbJWiWxeDgGLhRagM7tHGGIrzoxLS40UU9lG7BgC_ilbBt7Qh4JiM3bWlz3FA

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, Apr 19 2016

Cc: kcc@chromium.org aizatsky@chromium.org
Owner: pbos@chromium.org

Comment 2 by pbos@chromium.org, Apr 19 2016

Cc: pbos@chromium.org hlundin@chromium.org
Owner: kwiberg@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/3fc8e8dde365392da56724a33c2b8a05f5da75d2

commit 3fc8e8dde365392da56724a33c2b8a05f5da75d2
Author: kwiberg <kwiberg@webrtc.org>
Date: Fri May 20 11:40:29 2016

Fix UBSan errors (left shift of negative value)

BUG= chromium:604803 

Review-Url: https://codereview.webrtc.org/1988113003
Cr-Commit-Position: refs/heads/master@{#12826}

[modify] https://crrev.com/3fc8e8dde365392da56724a33c2b8a05f5da75d2/webrtc/modules/audio_coding/codecs/ilbc/do_plc.c

Status: Fixed (was: Assigned)
The CL in comment #3 fixes the bug according to my manual testing.
Project Member

Comment 5 by ClusterFuzz, Jun 9 2016

ClusterFuzz has detected this issue as fixed in range 396407:396452.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6325037115637760

Fuzzer: libfuzzer_audio_decoder_ilbc_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcIlbcfix_DoThePlc
  WebRtcIlbcfix_DecodeImpl
  WebRtcIlbcfix_Decode
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=386932:386961
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=396407:396452

Minimized Testcase (0.35 Kb): https://cluster-fuzz.appspot.com/download/AMIfv962ITns8Xa0CzeMCcVL1hd2h7O8V2BSxTBuj0eZVYlZCrp30i6GUc_NFLRUJWJaUV-fjRiquwS-JbCPRWS36GzTAzwtu7FE7sMJPDCiRSpd_gjUziXDKgOCs623EocwIaftNVnCzZmAowEz3WJ8-LXk09OdYg

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment