New issue
Advanced search Search tips

Issue 604800 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug


Participants' hotlists:
dmurph-future-tasks


Sign in to add a comment

Support blob construction in browser with passing a reference to Renderer.

Project Member Reported by dmu...@chromium.org, Apr 19 2016

Issue description

Currently there's no way of incrementing the refcount FOR the renderer, we rely on the blob sticking around for the transport by using a timer or something else hacky.

Let's make a way to create a blob for a renderer from the browser process so we're not doing crazy refcount hacks.
 

Comment 1 by dcheng@chromium.org, Apr 19 2016

Cc: dcheng@chromium.org

Comment 2 by dmu...@chromium.org, Sep 26 2016

Labels: dmurph-future-tasks

Comment 3 by dmu...@chromium.org, Apr 18 2017

Labels: -dmurph-future-tasks
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e2d638a9059794d68df60f6f7559f1ad141ccf

commit f4e2d638a9059794d68df60f6f7559f1ad141ccf
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Jan 26 19:44:30 2018

Take advantage of mojo blobs for lifetime management in clipboard code.

Bug:  604800 , 769024, 740744
Change-Id: I2267b1015e3c9ad0d3dfe019572ff328557e0112
Reviewed-on: https://chromium-review.googlesource.com/882483
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532042}
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/browser/renderer_host/clipboard_host_impl.cc
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/public/browser/blob_handle.h
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/Source/platform/exported/WebClipboardImpl.cpp
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/blob/blob.mojom
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/clipboard/clipboard.mojom
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/message_port/message_port.mojom

Comment 5 by mek@chromium.org, Jan 26 2018

Cc: dmu...@chromium.org
Owner: mek@chromium.org
Status: Fixed (was: Assigned)
There's still a few places that need cleaning up to actually do this correctly (mostly in extensions code), but this bug of having some way of doing it is fixed.

Sign in to add a comment