New issue
Advanced search Search tips

Issue 604795 link

Starred by 2 users
Status: Fixed
Owner:
qiangchen@chromium.org
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

WebMediaPlayerMS does not trigger Resize event correctly

Project Member Reported by qiangchen@chromium.org, Apr 19 2016 
Version: M52

What steps will reproduce the problem?
1) resize the window between below qvga and above 720p: the client should 
request diff res of the same main stage video. 
2) join a multi party meeting and pin different participants. 
3) have a mobile participant join the meeting and rotate their camera. 
Observe the mobile participant on the desktop. 

What is the expected output?
The mobile participant's thumbnail preview should be displayed well.

What do you see instead?
The mobile participant's thumbnail preview is invisible.

The reason causing the situation is that WebMediaPlayerMS triggers resize event before the new sized frame gets displayed. So at the instant when resize event is triggered, the javascript will still see the old size and thus make wrong decision.


The original bug is 
https://buganizer.corp.google.com/u/0/issues/27029520
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4089952731e1ad0a6cf83764042d59a41fbc42fe

commit 4089952731e1ad0a6cf83764042d59a41fbc42fe
Author: qiangchen <qiangchen@chromium.org>
Date: Thu Apr 21 00:29:29 2016

Bug Fix: Resize Event Trigger

WebMediaPlayerMS triggers Resize event when the new sized frame
enters the player. However, one would need to wait some time
(~30 ms) for that frame to be displayed. Thus at the instant when
resize is triggered, javascript is still seeing the old size.

In this CL, we move the trigger to when |current_frame_| is updated.

BUG= 604795 

Review URL: https://codereview.chromium.org/1895233003

Cr-Commit-Position: refs/heads/master@{#388635}

[modify] https://crrev.com/4089952731e1ad0a6cf83764042d59a41fbc42fe/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/4089952731e1ad0a6cf83764042d59a41fbc42fe/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/4089952731e1ad0a6cf83764042d59a41fbc42fe/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/4089952731e1ad0a6cf83764042d59a41fbc42fe/content/renderer/media/webmediaplayer_ms_unittest.cc

Comment 2 by qiangchen@chromium.org, Apr 21 2016

Status: Fixed (was: Assigned)

Comment 3 by qiangchen@chromium.org, Apr 25 2016

Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 25 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/830d9ac1cd65e02851381a4fb4ce3053c6ca2f9d

commit 830d9ac1cd65e02851381a4fb4ce3053c6ca2f9d
Author: qiangchen <qiangchen@chromium.org>
Date: Mon Apr 25 21:22:01 2016

Bug Fix: Resize Event Trigger

WebMediaPlayerMS triggers Resize event when the new sized frame
enters the player. However, one would need to wait some time
(~30 ms) for that frame to be displayed. Thus at the instant when
resize is triggered, javascript is still seeing the old size.

In this CL, we move the trigger to when |current_frame_| is updated.

BUG= 604795 

Review URL: https://codereview.chromium.org/1895233003

Cr-Commit-Position: refs/heads/master@{#388635}
(cherry picked from commit 4089952731e1ad0a6cf83764042d59a41fbc42fe)

NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1915123002

Cr-Commit-Position: refs/branch-heads/2704@{#231}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/830d9ac1cd65e02851381a4fb4ce3053c6ca2f9d/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/830d9ac1cd65e02851381a4fb4ce3053c6ca2f9d/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/830d9ac1cd65e02851381a4fb4ce3053c6ca2f9d/content/renderer/media/webmediaplayer_ms_compositor.cc
►

Sign in to add a comment