New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604794 link

Starred by 1 user
Status: Fixed
Owner:
zmo@chromium.org
Closed: Jul 2016
Cc:
█ kbr@chromium.org
geoffl...@chromium.org
bajones@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

glClientWaitSync doesn't validate the flags

Project Member Reported by cwallez@chromium.org, Apr 19 2016 
When running deqp/functional/gles3/negativefragmentapi.html, the 
negativeFragmentApi.client_wait_sync test checks that passing an invalid flag returns an error. The command buffer never validates the flag and there is GL_NO_ERROR.

This was found while running the WebGL2 CTS with --use-gl=angle but reproduced without the flag too.

Comment 1 by kbr@chromium.org, Jun 22 2016

Blocking: 429053
Components: Blink>WebGL
Labels: -Pri-3 Pri-2
It looks like this sharded tryjob:
https://chromium-swarm.appspot.com/user/task/2f929a0650bb2910

from this CL:
https://codereview.chromium.org/2077443002/

ran into this problem. Log excerpt attached.

Bumping to P2 and
stdout.txt
42.7 KB View Download

Comment 2 by kbr@chromium.org, Jun 22 2016

Cc: zmo@chromium.org
Owner: ----
...adding a flaky suppression.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22abf1da88a9ef1fb1d800bc8c58a6d3aeec7082

commit 22abf1da88a9ef1fb1d800bc8c58a6d3aeec7082
Author: zmo <zmo@chromium.org>
Date: Thu Jun 23 23:33:29 2016

Improve sync object related command handling.

BUG= 429053 , 604794 
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2095493002
Cr-Commit-Position: refs/heads/master@{#401755}

[modify] https://crrev.com/22abf1da88a9ef1fb1d800bc8c58a6d3aeec7082/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/22abf1da88a9ef1fb1d800bc8c58a6d3aeec7082/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/22abf1da88a9ef1fb1d800bc8c58a6d3aeec7082/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

Comment 4 by zmo@chromium.org, Jul 1 2016

Cc: -zmo@chromium.org
Labels: OS-Linux
Owner: zmo@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment