New issue
Advanced search Search tips

Issue 604792 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Failed USB enumerations are retried indefinitely

Project Member Reported by reillyg@chromium.org, Apr 19 2016

Issue description

When usb_service_impl.cc fails to enumerate a device or decides to skip it the next call to RefreshDevices() will try again to enumerate it, indefinitely. This causes log spam and means Chrome keeps trying to mess with devices it doesn't have access to.
 

Comment 1 by juncai@chromium.org, Apr 21 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d23f2ba75f50575513dcbde328c6041e4d47716c

commit d23f2ba75f50575513dcbde328c6041e4d47716c
Author: juncai <juncai@chromium.org>
Date: Wed Apr 27 23:32:26 2016

Store devices that only need to be enumerated once

Some devices that only need to be enumerated once and then
can be ignored (for example, hub devices, devices that
failed enumeration, etc.). Currently these devices are
enumerated each time UsbServiceImpl::EnumerateDevice() is
called since they are added to |new_devices| at
UsbServiceImpl::OnDeviceList(). This patch add code to
store those devices and not enumerate them again.

BUG= 604792 

Review-Url: https://codereview.chromium.org/1903933002
Cr-Commit-Position: refs/heads/master@{#390234}

[modify] https://crrev.com/d23f2ba75f50575513dcbde328c6041e4d47716c/device/usb/usb_service_impl.cc
[modify] https://crrev.com/d23f2ba75f50575513dcbde328c6041e4d47716c/device/usb/usb_service_impl.h

Comment 3 by juncai@chromium.org, Apr 28 2016

Status: Fixed (was: Started)

Sign in to add a comment