New issue
Advanced search Search tips

Issue 604790 link

Starred by 2 users
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Apr 2016
Cc:
rbyers@chromium.org
tdres...@chromium.org
lanwei@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 599609



Sign in to add a comment

Add uma metric to determine how touch start and first touch moves are handled.

Project Member Reported by dtapu...@chromium.org, Apr 19 2016 
Add a uma metric to determine the following:

How many listeners are invoked
1) Non Root level target on a non-scrollable document, not handled.
2) Non Root level target on a non-scrollable document, prevent defaulted.
3) Non Root level target on a scrollable document, not handled.
4) Non Root level target on a scrollable document, prevent defaulted.
5) Root level target on a non-scrollable document, not handled.
6) Root level target on a non-scrollable document, prevent defaulted.
7) Root level target on a scrollable document, not handled.
8) Root level target on a scrollable document, prevent defaulted.

UMA metric name will be:

Event.Listeners.TouchBlockingOnRootElements

Comment 1 by dtapu...@chromium.org, Apr 21 2016 

Metric will be instead named Event.Touch.TargetAndDispatchResult

Comment 2 by dtapu...@chromium.org, Apr 21 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c21fd3ea10e3111566b4c912a00d4c6cd8474d7f

commit c21fd3ea10e3111566b4c912a00d4c6cd8474d7f
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Apr 22 15:53:48 2016

Add UMA metric for tracking root level listeners for blocking touch.

In order to quantify the benefit of making document level touch
listeners passive for a possible intervention measure the behavior
of touch events on the root document.

BUG= 604790 

Review URL: https://codereview.chromium.org/1864523004

Cr-Commit-Position: refs/heads/master@{#389122}

[modify] https://crrev.com/c21fd3ea10e3111566b4c912a00d4c6cd8474d7f/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/c21fd3ea10e3111566b4c912a00d4c6cd8474d7f/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/c21fd3ea10e3111566b4c912a00d4c6cd8474d7f/tools/metrics/histograms/histograms.xml

Comment 4 by dtapu...@chromium.org, Apr 26 2016

Labels: Merge-Request-51

Comment 5 by tin...@google.com, Apr 26 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 6 by dtapu...@chromium.org, Apr 26 2016

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e2219e115b217c4d7aba70b5f627026d5a66dd

commit 39e2219e115b217c4d7aba70b5f627026d5a66dd
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Apr 26 14:37:27 2016

Add UMA metric for tracking root level listeners for blocking touch.

In order to quantify the benefit of making document level touch
listeners passive for a possible intervention measure the behavior
of touch events on the root document.

BUG= 604790 

Review URL: https://codereview.chromium.org/1864523004

Cr-Commit-Position: refs/heads/master@{#389122}
(cherry picked from commit c21fd3ea10e3111566b4c912a00d4c6cd8474d7f)

Review URL: https://codereview.chromium.org/1922893002 .

Cr-Commit-Position: refs/branch-heads/2704@{#247}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/39e2219e115b217c4d7aba70b5f627026d5a66dd/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/39e2219e115b217c4d7aba70b5f627026d5a66dd/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/39e2219e115b217c4d7aba70b5f627026d5a66dd/tools/metrics/histograms/histograms.xml

Comment 8 by tdres...@chromium.org, Apr 27 2016

Blocking: 599609
Project Member

Comment 9 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05f9fdad56cd5018c8fb31f1866b232d7444f796

commit 05f9fdad56cd5018c8fb31f1866b232d7444f796
Author: dtapuska <dtapuska@chromium.org>
Date: Fri May 20 03:33:41 2016

Add UMA metric for tracking root level listeners for blocking touch.

Adjust histogram to capture on each phase of targeting the event instead
of the old histogram which targeted only where the event handler was
registered.

BUG= 604790 

Review-Url: https://codereview.chromium.org/1980113002
Cr-Commit-Position: refs/heads/master@{#394982}

[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/core/events/EventTarget.h
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/core/events/NodeEventContext.cpp
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/core/events/TouchEvent.h
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/05f9fdad56cd5018c8fb31f1866b232d7444f796/tools/metrics/histograms/histograms.xml

Comment 10 by dtapu...@chromium.org, May 24 2016

Labels: -Hotlist-Merge-Approved -merge-merged-2704 Merge-Request-52

Comment 11 by tin...@google.com, May 24 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 12 by bugdroid1@chromium.org, May 24 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bc81470610ce15506855900f93f255280a04a1a

commit 1bc81470610ce15506855900f93f255280a04a1a
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue May 24 20:09:25 2016

Add UMA metric for tracking root level listeners for blocking touch.

Adjust histogram to capture on each phase of targeting the event instead
of the old histogram which targeted only where the event handler was
registered.

BUG= 604790 

Review-Url: https://codereview.chromium.org/1980113002
Cr-Commit-Position: refs/heads/master@{#394982}
(cherry picked from commit 05f9fdad56cd5018c8fb31f1866b232d7444f796)

Review URL: https://codereview.chromium.org/2007733003 .

Cr-Commit-Position: refs/branch-heads/2743@{#41}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/core/events/EventTarget.h
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/core/events/NodeEventContext.cpp
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/core/events/TouchEvent.h
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/1bc81470610ce15506855900f93f255280a04a1a/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment