New issue
Advanced search Search tips

Issue 604775 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Build failure

Project Member Reported by cmumford@chromium.org, Apr 19 2016

Issue description

Build is broken:
Instrumentation test ContentShellTest

Revision range:
chromium 388202 : 388207

Failing builders:
Android GN: https://build.chromium.org/p/chromium.linux/builders/Android%20GN
 
Speculating that https://codereview.chromium.org/1896073002 may be the cause because it is related to date/time as are the failing tests.

Comment 2 by tkent@chromium.org, Apr 19 2016

Cc: agrieve@chromium.org
ui/base doesn't depend on third_party/WebKit.

https://codereview.chromium.org/1898033004 looks related to this issue.

Comment 3 by tkent@chromium.org, Apr 19 2016

Oh, I misunderstood this issue, which is about ContentShellTest.

IME-relaeted tests are very flaky today on Andoroid bots.

Comment 4 by tkent@chromium.org, Apr 19 2016

Status: WontFix (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3890633d575fd3a0ac412570e0bfa015bec58c95

commit 3890633d575fd3a0ac412570e0bfa015bec58c95
Author: rtoy <rtoy@chromium.org>
Date: Wed Apr 20 20:06:01 2016

Throw error if timeConstant is not positive for setTargetAtTime

If the timeConstant is not strictly positive, setTargetAtTime should
throw an error.

BUG= 604775 
TEST=audioparam-exceptional-values.html updated with new test

Review URL: https://codereview.chromium.org/1897293002

Cr-Commit-Position: refs/heads/master@{#388560}

[modify] https://crrev.com/3890633d575fd3a0ac412570e0bfa015bec58c95/third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values-expected.txt
[modify] https://crrev.com/3890633d575fd3a0ac412570e0bfa015bec58c95/third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html
[modify] https://crrev.com/3890633d575fd3a0ac412570e0bfa015bec58c95/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp

Sign in to add a comment