New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604771 link

Starred by 0 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Dec 2017
Cc:
█ jered@chromium.org
treib@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Investigate why search::MatchesOriginAndPath considers http equal https

Project Member Reported by treib@chromium.org, Apr 19 2016 
...and see if we can maybe get rid of that.

From jered@ on https://codereview.chromium.org/1891233002/:
I don't remember exactly what case required this funny logic but it's
intentional.
I remember that new profiles sometimes use http urls for the default search
provider, which we upgrade to https via search domain check or a redirect. And
at
the time it's possible some affected search pages were served over http.
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 20 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by treib@chromium.org, Apr 25 2017

Owner: treib@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by fhorschig@google.com, Aug 3 2017

Labels: -Hotlist-Recharge-Cold zine-triaged

Comment 4 by treib@chromium.org, Nov 15 2017

Labels: -Type-Bug Type-Task
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b1dc993cb9057ef4b2bc1b2df35f2d311db8148

commit 1b1dc993cb9057ef4b2bc1b2df35f2d311db8148
Author: Marc Treib <treib@chromium.org>
Date: Fri Dec 01 11:39:07 2017

Cleanup: Merge c/c/search/search_urls.h/cc into c/b/search/search.cc

The functions there are only used within search.cc. They're also weird
and shouldn't be used by anyone, so as a first step, let's make them as
invisible as possible.

Bug:  604771 
Change-Id: I23e373437b0e7882fbcc1de5a83321f2f26903d2
Reviewed-on: https://chromium-review.googlesource.com/800551
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520915}
[modify] https://crrev.com/1b1dc993cb9057ef4b2bc1b2df35f2d311db8148/chrome/browser/search/search.cc
[modify] https://crrev.com/1b1dc993cb9057ef4b2bc1b2df35f2d311db8148/chrome/browser/search/search_unittest.cc
[modify] https://crrev.com/1b1dc993cb9057ef4b2bc1b2df35f2d311db8148/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/1b1dc993cb9057ef4b2bc1b2df35f2d311db8148/chrome/common/BUILD.gn
[delete] https://crrev.com/d23ef9a21faeaadc907c80bd05dd5ee0f992bafd/chrome/common/search/search_urls.cc
[delete] https://crrev.com/d23ef9a21faeaadc907c80bd05dd5ee0f992bafd/chrome/common/search/search_urls.h
[delete] https://crrev.com/d23ef9a21faeaadc907c80bd05dd5ee0f992bafd/chrome/common/search/search_urls_unittest.cc
[modify] https://crrev.com/1b1dc993cb9057ef4b2bc1b2df35f2d311db8148/chrome/test/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/add16f941dced2083901ce42a02ba4b3d99843ab

commit add16f941dced2083901ce42a02ba4b3d99843ab
Author: Marc Treib <treib@chromium.org>
Date: Fri Dec 08 08:52:24 2017

search::MatchesOriginAndPath: Remove special case for http matching https

As far as I can tell, whatever reason there was for this hack doesn't
apply anymore.

Bug:  604771 
Change-Id: Ic96002d54a94ed9d795b33dc5f8493c7e623c00e
Reviewed-on: https://chromium-review.googlesource.com/814118
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522740}
[modify] https://crrev.com/add16f941dced2083901ce42a02ba4b3d99843ab/chrome/browser/search/search.cc
[modify] https://crrev.com/add16f941dced2083901ce42a02ba4b3d99843ab/chrome/browser/search/search_unittest.cc

Comment 7 by treib@chromium.org, Dec 8 2017

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Assigned)
Alright, it's gone. Let's see if this broke anything...
►

Sign in to add a comment