New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604763 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Build failure

Project Member Reported by cmumford@chromium.org, Apr 19 2016

Issue description

Build is broken:
chrome_junit_tests

Revision range:
chromium 388195 : 388203

Failing builders:
Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)


 
Original change (#388195) was reverted.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb0b829783d26fe083f951a58c2395bef0f06840

commit cb0b829783d26fe083f951a58c2395bef0f06840
Author: dgn <dgn@chromium.org>
Date: Tue Apr 19 17:35:04 2016

[NTP Snippets] Refresh the displayed snippets less frequently

Relanding the change that was reverted in
https://codereview.chromium.org/1897313002

Original issue's description:
> The fetch frequence of the snippet service does not change, but the
> snippets are now refreshed less frequently on the UI. They are pulled
> when the NTP is opened, or when the user switches back to it from
> another tab or another app.
>
> Additionally, we also change the way the list is updated, adding only
> new entries instead of clearing the old list and replacing it with
> the new one.

BUG= 601757 , 604763 
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/1898213002

Cr-Commit-Position: refs/heads/master@{#388235}

[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/android/BUILD.gn
[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[add] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/components/ntp_snippets/ntp_snippets_service.cc

Comment 3 by dgn@chromium.org, Apr 20 2016

Status: Fixed (was: Available)

Sign in to add a comment