New issue
Advanced search Search tips

Issue 604743 link

Starred by 1 user
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

preventDefault on a non-document target with passive listener doesn't log

Project Member Reported by dtapu...@chromium.org, Apr 19 2016 
An error should be reported to the console.

The code loads the current target and tries to convert it to a LocalDOMWindow which will only do an upcast if the object is of the right type.

We should load the dom window from the event path instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c55f4ccbd722aa7eaa4e94309661e10d128ae098

commit c55f4ccbd722aa7eaa4e94309661e10d128ae098
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Apr 19 17:52:36 2016

Report passive prevent defaulted event listeners correctly to the console.

Previously only document level listeners would be reported to the console
that were preventDefaulted.

Load the LocalDOMWindow from the event path instead.

BUG= 604743 

Review URL: https://codereview.chromium.org/1897953004

Cr-Commit-Position: refs/heads/master@{#388240}

[modify] https://crrev.com/c55f4ccbd722aa7eaa4e94309661e10d128ae098/third_party/WebKit/Source/core/events/Event.cpp

Comment 2 by dtapu...@chromium.org, Apr 21 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15ffa10a8f58ea73838f2ca12a1dd57517102633

commit 15ffa10a8f58ea73838f2ca12a1dd57517102633
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Apr 21 15:35:16 2016

Report passive prevent defaulted event listeners correctly to the console.

Previously only document level listeners would be reported to the console
that were preventDefaulted.

Load the LocalDOMWindow from the event path instead.

BUG= 604743 

Review URL: https://codereview.chromium.org/1897953004

Cr-Commit-Position: refs/heads/master@{#388240}
(cherry picked from commit c55f4ccbd722aa7eaa4e94309661e10d128ae098)

Review URL: https://codereview.chromium.org/1904103002 .

Cr-Commit-Position: refs/branch-heads/2704@{#163}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/15ffa10a8f58ea73838f2ca12a1dd57517102633/third_party/WebKit/Source/core/events/Event.cpp

Comment 5 by dtapu...@chromium.org, Apr 21 2016

Labels: M-51
Status: Fixed (was: Assigned)
►

Sign in to add a comment