New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604740 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 584266



Sign in to add a comment

Allow dumping the snippets state via chrome://snippets-internals

Project Member Reported by dgn@chromium.org, Apr 19 2016

Issue description

This is to be able to get some data about the state of the snippets when trying to reproduce a bug.

Make chrome put a file in the downloads folder that could be attached and sent by email/hangouts/whatever or adb-pull'ed.
 

Comment 1 by jkrcal@chromium.org, Apr 19 2016

Do you have any specific format on your mind for the dumped file?

Comment 2 by bauerb@chromium.org, Apr 19 2016

We could just dump the state from prefs as JSON?

Comment 3 by fi...@chromium.org, Apr 20 2016

Labels: zine-mr-mile-MVP

Comment 4 by jkrcal@chromium.org, Apr 21 2016

Labels: zine-mr-iter-11 zine-mr-iter-12
A CL should be ready for review today EOB. It is a small CL, hope to land it soon.

Comment 5 by fi...@chromium.org, Apr 22 2016

Blocking: 584266
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8e57c751b135139f3666ad900f491e78744fcd

commit ab8e57c751b135139f3666ad900f491e78744fcd
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Apr 25 08:17:40 2016

Display status message for "Add snippets" on chrome://snippets-internals

The status message informs of URLRequest / HTTP error codes, invalid input, etc (604740). Furthermore, I enlarged the hosts input (605520).

BUG= 604740 ,  605520 

Review URL: https://codereview.chromium.org/1910633005

Cr-Commit-Position: refs/heads/master@{#389431}

[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.css
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ed0d72d80f4b4687889c83fc7f72dd9591cc659

commit 5ed0d72d80f4b4687889c83fc7f72dd9591cc659
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Apr 25 13:47:18 2016

Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals.

Also changes a few details in the JS for the internals page
(inlining callbacks, geting rid of the arrow function to pass
presubmit).

Introduces a getter in the service for snippets (the asymmetric
access via iterators to be removed in another CL).

BUG= 604740 

Review URL: https://codereview.chromium.org/1907233002

Cr-Commit-Position: refs/heads/master@{#389466}

[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/resources/snippets_internals.js
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/ui/webui/snippets_internals_message_handler.h
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/components/ntp_snippets/ntp_snippets_service.h

Comment 8 by jkrcal@chromium.org, Apr 25 2016

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8e57c751b135139f3666ad900f491e78744fcd

commit ab8e57c751b135139f3666ad900f491e78744fcd
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Apr 25 08:17:40 2016

Display status message for "Add snippets" on chrome://snippets-internals

The status message informs of URLRequest / HTTP error codes, invalid input, etc (604740). Furthermore, I enlarged the hosts input (605520).

BUG= 604740 ,  605520 

Review URL: https://codereview.chromium.org/1910633005

Cr-Commit-Position: refs/heads/master@{#389431}

[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.css
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ed0d72d80f4b4687889c83fc7f72dd9591cc659

commit 5ed0d72d80f4b4687889c83fc7f72dd9591cc659
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Apr 25 13:47:18 2016

Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals.

Also changes a few details in the JS for the internals page
(inlining callbacks, geting rid of the arrow function to pass
presubmit).

Introduces a getter in the service for snippets (the asymmetric
access via iterators to be removed in another CL).

BUG= 604740 

Review URL: https://codereview.chromium.org/1907233002

Cr-Commit-Position: refs/heads/master@{#389466}

[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/resources/snippets_internals.js
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/chrome/browser/ui/webui/snippets_internals_message_handler.h
[modify] https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659/components/ntp_snippets/ntp_snippets_service.h

Labels: zine-mr-MVP

Comment 12 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp
Labels: zine-mr-MVP

Sign in to add a comment