Worth looking into as a plugin for Gerrit

Issue 650208 has been merged into this issue.

+1 to having this be officially supported in PolyGerrit.

Extensions of this type are popular, and having it built-in would solve one issue, which is that Chromite Butler does not implement all of the OWNERS file logic (in particular, it doesn't expand file: references), and allow us to ensure that this is maintained as depot_tools' OWNERS syntax evolves.

I've semi-frequently gotten requests to stamp a CL that already had complete OWNERS coverage.

IMO, owner logic should actually be part of a Gerrit plugin.

 Issue 692079  has been merged into this issue.

From the bug just duped into this one:

Someone on Android is working on a find-owners plugin: go/android-owners

Definitely chime in if you have any specific concerns or feature requests :)

 Issue 690760  has been merged into this issue.

I rely heavily on the chromite butler today. I've just hit another case of trying to submit a CL, discovering that I've missed an owner for a file, not having the owner in the office, and losing velocity. Other folks on my team have hit the same problem.

Even a minimal port of the butler would be a huge help for my gerrit migration and full, official support, as jbroman@ points out, would be amazing.

FTR: I'm actually supposed to test Gerrit OWNERS plugin which is already being used in Android land. The plugin doesn't have UI for Chromium however.

Yep, trust me, we really really want to support OWNERS display, reviewer suggestions, an "uncovered" file coloring. These are definitely things that we plan to work on, because they're awesome features. We just can't say that we'll do them before we flip the default or before we make Rietveld read-only, because they're not technically Rietveld features that we're required to port over.

We're going to do this, and we're going to do it awesomely, we just can't do it immediately :)

 Issue 735136  has been merged into this issue.

As noted in the bug that I just merged into this one, carlosk@ is working on this during Chrome Camp! Yay!

I started looking into this. I don't think I'll have enough time to get to anything useful during Chrome Camp but I intend to keep working on it as a side project.

Just a note that the Chromite Butler extension was updated to partially fulfill these functions. It can be used while we don't have it implemented as a plugin.

@c18 Sadrul and I got tired of waiting that we hacked some basic thing together. Something built in would be more reliable however.

Is there a design doc?
I remember we had a meeting with carlosk@, but I'm not sure I've seen it.
One of the reasons I'm asking for it is because the timeline isn't clear for me. The other is to understand better the requirements.
We've discussed plugin API for decorating file list elements in the inline diff, would that be sufficient?

With the improvements made to the extension I don't think this has a lower priority now.

FYI: find-owners is now supported in PolyGerrit.

Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

The extension has been great, but it's time to finally do this via the find-owners plugin. Repurposing this bug to track the remaining work for the plugin implementation.

 Issue 753411  has been merged into this issue.