With NSS being removed from iOS, we can now remove most of the remaining NSS bits: * Remove USE_OPENSSL flags/macros. * Removes _nss and merge _openssl with base.
(Hrm, I guess that "blockedon" relationship could go in either direction. I meant it more in the "tracking bug" sense.)
I will try to do it. Thanks. Do not expect it to be done quickly as long as I am still familiarizing myself with the net/*
Steven's already got a CL uploaded for a large part of this. (Marking this as started so this is clearer.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2135be5210856ba79bdb774166af869342c5dddf commit 2135be5210856ba79bdb774166af869342c5dddf Author: svaldez <svaldez@chromium.org> Date: Wed Apr 20 16:34:53 2016 This removes most of the NSS files and both the use_openssl build argument and macro since we no longer have any platforms using NSS for crypto/SSL. BUG= 604728 TBR=kelvinp@chromium.org Review URL: https://codereview.chromium.org/1882433002 Cr-Commit-Position: refs/heads/master@{#388517} [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/all.gyp [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/android/pylib/utils/isolator.py [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/common.gypi [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/config/BUILD.gn [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/config/crypto.gni [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/gn_migration.gypi [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/isolate.gypi [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/build/linux/system.gyp [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/chromeos/BUILD.gn [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/components/certificate_reporting/error_reporter.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/components/certificate_reporting/error_reporter.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/components/certificate_reporting/error_reporter_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/components/components_tests.gyp [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/components/gcm_driver.gypi [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/components/gcm_driver/crypto/BUILD.gn [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/components/gcm_driver/crypto/gcm_message_cryptographer_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/components/gcm_driver/crypto/p256_key_util_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/components/variations/variations_seed_store_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/content/browser/browser_main_loop.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/content/test/BUILD.gn [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/BUILD.gn [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/aead_openssl.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/aead_openssl_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/crypto.gyp [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/crypto.gypi [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/curve25519-donna.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/curve25519_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/ec_private_key.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/ec_private_key_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/ec_private_key_unittest.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/ec_signature_creator_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/encryptor.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/encryptor_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/hmac_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/rsa_private_key.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/rsa_private_key_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/secure_hash_default.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/signature_creator.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/signature_creator_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/signature_verifier.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/signature_verifier_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/crypto/symmetric_key.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/symmetric_key_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/third_party/nss/pk11akey.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/third_party/nss/rsawrapr.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/crypto/third_party/nss/secsign.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/ios/chrome/browser/ios_chrome_io_thread.mm [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/ios/crnet/crnet_environment.mm [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/ios/web/app/web_main_loop.mm [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/BUILD.gn [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/base/nss_memio.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/base/nss_memio.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/cert_verify_proc.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/cert_verify_proc_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/ct_log_verifier.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/cert/ct_log_verifier_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/cert/ct_objects_extractor_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/ev_root_ca_metadata.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/ev_root_ca_metadata.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/internal/signature_policy.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/internal/verify_certificate_chain_pkits_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/internal/verify_certificate_chain_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/internal/verify_signed_data.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/internal/verify_signed_data_unittest.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/cert/jwk_serializer_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/multi_threaded_cert_verifier.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/test_root_certs.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/test_root_certs_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/x509_certificate_ios.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/cert/x509_certificate_openssl_ios.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/x509_certificate_win.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/cert/x509_util_ios.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/cert/x509_util_ios.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/x509_util_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/x509_util_nss.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/cert/x509_util_nss_certs.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/cert/x509_util_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/http/des.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/http/transport_security_state_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/net.gyp [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/net.gypi [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/net_common.gypi [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/aead_base_decrypter.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/aead_base_decrypter_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/aead_base_encrypter.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/aead_base_encrypter_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/aes_128_gcm_12_decrypter.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/aes_128_gcm_12_decrypter_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/aes_128_gcm_12_encrypter.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/aes_128_gcm_12_encrypter_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/chacha20_poly1305_decrypter.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/chacha20_poly1305_encrypter.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/chacha20_poly1305_rfc7539_decrypter.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/chacha20_poly1305_rfc7539_decrypter_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/chacha20_poly1305_rfc7539_encrypter.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/chacha20_poly1305_rfc7539_encrypter_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/channel_id_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/crypto/p256_key_exchange.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/p256_key_exchange_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/crypto/proof_source_chromium_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/quic_stream_factory.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/quic/test_tools/crypto_test_utils_chromium.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/quic/test_tools/crypto_test_utils_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/socket/client_socket_factory.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/socket/nss_ssl_util.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/socket/nss_ssl_util.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/socket/ssl_client_socket.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/socket/ssl_client_socket_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/socket/ssl_client_socket_nss.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/socket/ssl_client_socket_openssl.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/socket/ssl_client_socket_unittest.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/socket/ssl_server_socket_nss.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/socket/ssl_server_socket_nss.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/socket/ssl_server_socket_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/ssl/channel_id_service.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/ssl/ssl_cipher_suite_names.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/ssl/token_binding_nss.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/test/embedded_test_server/embedded_test_server_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/test/net_test_suite.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/test/run_all_unittests.cc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/applypatches.sh [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/cachecerts.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/cachelocks.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/channelid.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/cipherorder.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/didhandshakeresume.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/getrequestedclientcerttypes.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/ignorechangecipherspec.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/nobypass.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/reorderextensions.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/restartclientauth.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/secretexporterlocks.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/sessioncache.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/patches/tlsunique.patch [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl.gyp [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/BUILD.gn [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/Makefile [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/SSLerrs.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/authcert.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/derive.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/dhe-param.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/dtlscon.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/manifest.mn [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/notes.txt [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/os2_err.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/os2_err.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/preenc.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/prelib.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssl.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssl.rc [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssl3con.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssl3ecc.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssl3ext.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssl3gthr.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssl3prot.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslauth.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslcon.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssldef.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslenum.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslerr.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslerr.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslerrstrs.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslgathr.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslimpl.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslinfo.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslinit.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslmutex.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslmutex.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslnonce.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslproto.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslreveal.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslsecur.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslsnce.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslsock.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslt.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/ssltrace.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/sslver.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/tls13con.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/tls13con.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/tls13hkdf.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/tls13hkdf.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/unix_err.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/unix_err.h [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/win32err.c [delete] https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1/net/third_party/nss/ssl/win32err.h [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/url_request/url_fetcher_impl_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/net/url_request/url_request_unittest.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/remoting/host/token_validator_base.cc [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/tools/copyright_scanner/third_party_files_whitelist.txt [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/tools/gn/docs/cookbook.md [modify] https://crrev.com/2135be5210856ba79bdb774166af869342c5dddf/tools/grit/grit_rule.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba3958ab196964def88e432393b110f45f795ef8 commit ba3958ab196964def88e432393b110f45f795ef8 Author: svaldez <svaldez@chromium.org> Date: Wed Apr 20 18:36:41 2016 Remove use_openssl variable This removes the definition of use_openssl from build/common.gypi since nothing should be relying on it anymore. R=thakis@chromium.org BUG= 604728 Review URL: https://codereview.chromium.org/1904453002 Cr-Commit-Position: refs/heads/master@{#388539} [modify] https://crrev.com/ba3958ab196964def88e432393b110f45f795ef8/build/common.gypi [modify] https://crrev.com/ba3958ab196964def88e432393b110f45f795ef8/build/config/crypto.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9fd1be22cfa3c1e87e2a8d8660b4c2f64390d37 commit f9fd1be22cfa3c1e87e2a8d8660b4c2f64390d37 Author: svaldez <svaldez@chromium.org> Date: Wed Apr 20 19:23:23 2016 Remove extraneous USE_NSS_VERIFIER macros BUG= 604728 Review URL: https://codereview.chromium.org/1910523002 Cr-Commit-Position: refs/heads/master@{#388546} [modify] https://crrev.com/f9fd1be22cfa3c1e87e2a8d8660b4c2f64390d37/components/cronet/ios/cronet_environment.cc [modify] https://crrev.com/f9fd1be22cfa3c1e87e2a8d8660b4c2f64390d37/net/cert/test_root_certs_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22de42fecbdc7d132c086dec7744033ff20af55e commit 22de42fecbdc7d132c086dec7744033ff20af55e Author: svaldez <svaldez@chromium.org> Date: Thu Apr 21 19:42:22 2016 Rename crypto/ *_openssl files With the removal of most of the NSS code, we no longer need to split up code between NSS and OpenSSL implementations. BUG= 604728 Review URL: https://codereview.chromium.org/1909513003 Cr-Commit-Position: refs/heads/master@{#388856} [modify] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/components/certificate_reporting/error_reporter.cc [modify] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/BUILD.gn [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/aead.cc [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/aead.h [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/aead_unittest.cc [modify] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/crypto.gyp [modify] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/crypto.gypi [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/curve25519.cc [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/ec_private_key.cc [modify] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/encryptor.cc [modify] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/encryptor.h [delete] https://crrev.com/40a09e787b4aba33fcd27672b4763fecf13c3623/crypto/encryptor_openssl.cc [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/rsa_private_key.cc [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/secure_hash.cc [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/signature_creator.cc [rename] https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e/crypto/signature_verifier.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0187a49c43ecf1d0867776c14a20f1788d76ff1 commit e0187a49c43ecf1d0867776c14a20f1788d76ff1 Author: svaldez <svaldez@chromium.org> Date: Fri Apr 22 16:10:11 2016 Remove *_openssl files for gcm_driver BUG= 604728 Review URL: https://codereview.chromium.org/1910903002 Cr-Commit-Position: refs/heads/master@{#389130} [modify] https://crrev.com/e0187a49c43ecf1d0867776c14a20f1788d76ff1/components/gcm_driver.gypi [modify] https://crrev.com/e0187a49c43ecf1d0867776c14a20f1788d76ff1/components/gcm_driver/crypto/BUILD.gn [modify] https://crrev.com/e0187a49c43ecf1d0867776c14a20f1788d76ff1/components/gcm_driver/crypto/gcm_message_cryptographer.cc [modify] https://crrev.com/e0187a49c43ecf1d0867776c14a20f1788d76ff1/components/gcm_driver/crypto/gcm_message_cryptographer.h [delete] https://crrev.com/b582bd87eef350aed20c52eb552bf5e101e01b58/components/gcm_driver/crypto/gcm_message_cryptographer_openssl.cc [modify] https://crrev.com/e0187a49c43ecf1d0867776c14a20f1788d76ff1/components/gcm_driver/crypto/p256_key_util.cc [delete] https://crrev.com/b582bd87eef350aed20c52eb552bf5e101e01b58/components/gcm_driver/crypto/p256_key_util_openssl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3df6ff1f5b8a0732469c57e56c805aefde17ebfe commit 3df6ff1f5b8a0732469c57e56c805aefde17ebfe Author: svaldez <svaldez@chromium.org> Date: Mon Apr 25 14:46:42 2016 Rename _openssl files in net/quic/ BUG= 604728 Review URL: https://codereview.chromium.org/1916463002 Cr-Commit-Position: refs/heads/master@{#389474} [modify] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/net.gypi [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/aead_base_decrypter.cc [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/aead_base_encrypter.cc [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/aes_128_gcm_12_decrypter.cc [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/aes_128_gcm_12_encrypter.cc [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/chacha20_poly1305_rfc7539_decrypter.cc [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/chacha20_poly1305_rfc7539_encrypter.cc [modify] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/channel_id.cc [delete] https://crrev.com/c7c0d3ab719b356d8ccef636506507b2cead7ff1/net/quic/crypto/channel_id_openssl.cc [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/p256_key_exchange.cc [rename] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/crypto/proof_source_chromium.cc [modify] https://crrev.com/3df6ff1f5b8a0732469c57e56c805aefde17ebfe/net/quic/test_tools/crypto_test_utils.cc [delete] https://crrev.com/c7c0d3ab719b356d8ccef636506507b2cead7ff1/net/quic/test_tools/crypto_test_utils_openssl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/938019f8964f7bf41312f8b1f8e2fd7f88194168 commit 938019f8964f7bf41312f8b1f8e2fd7f88194168 Author: svaldez <svaldez@chromium.org> Date: Mon Apr 25 16:10:52 2016 Removing use_openssl from cronet build With the removal of use_openssl, cronet no longer needs to explicitly set use_openssl. BUG= 604728 Review URL: https://codereview.chromium.org/1918863002 Cr-Commit-Position: refs/heads/master@{#389489} [modify] https://crrev.com/938019f8964f7bf41312f8b1f8e2fd7f88194168/components/cronet/tools/cr_cronet.py [modify] https://crrev.com/938019f8964f7bf41312f8b1f8e2fd7f88194168/components/cronet/tools/package_ios.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8539ccb7fbc802f753d2782642c6af522dc9caa commit b8539ccb7fbc802f753d2782642c6af522dc9caa Author: svaldez <svaldez@chromium.org> Date: Mon Apr 25 22:33:15 2016 Rename net/ _openssl files R=davidben@chromium.org BUG= 604728 Review URL: https://codereview.chromium.org/1918903002 Cr-Commit-Position: refs/heads/master@{#389590} [modify] https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa/net/cert/ct_log_verifier.cc [delete] https://crrev.com/8a2217e9cdc1f258eb010df74264c00fdf9a587d/net/cert/ct_log_verifier_openssl.cc [rename] https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa/net/cert/ct_objects_extractor.cc [rename] https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa/net/cert/jwk_serializer.cc [modify] https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa/net/net.gypi [modify] https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa/net/quic/quic_stream_factory.cc [rename] https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa/net/ssl/token_binding.cc [modify] https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa/net/ssl/token_binding.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e83af29319a191e36d2e4dc6519636f15e3de5d9 commit e83af29319a191e36d2e4dc6519636f15e3de5d9 Author: svaldez <svaldez@chromium.org> Date: Tue Apr 26 14:33:37 2016 Renaming _openssl files to _impl Since we no longer have NSS implementations, we rename all the _openssl specific implementations to _impl to align with the rest of the code base. TBR=kelvinp@chromium.org R=davidben@chromium.org, kelvinp@chromium.org BUG= 604728 Review URL: https://codereview.chromium.org/1921563003 Cr-Commit-Position: refs/heads/master@{#389776} [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/crypto/BUILD.gn [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/crypto/crypto.gypi [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/crypto/ec_signature_creator_impl.cc [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/android/keystore_openssl.cc [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/android/keystore_openssl.h [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/net.gypi [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/quic/quic_chromium_client_session.cc [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/socket/client_socket_factory.cc [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/socket/ssl_client_socket.cc [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/socket/ssl_client_socket_impl.cc [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/socket/ssl_client_socket_impl.h [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/socket/ssl_client_socket_unittest.cc [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/socket/ssl_server_socket_impl.cc [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/socket/ssl_server_socket_impl.h [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/ssl/ssl_client_session_cache.cc [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/ssl/ssl_client_session_cache.h [rename] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/net/ssl/ssl_client_session_cache_unittest.cc [modify] https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9/remoting/protocol/ssl_hmac_channel_authenticator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b40a33f27d3fb1757508c53cc7ffafa9e0d1bb commit 72b40a33f27d3fb1757508c53cc7ffafa9e0d1bb Author: svaldez <svaldez@chromium.org> Date: Tue Apr 26 16:54:38 2016 Removing debugging information for NSS and Valgrind Suppressions Since we no longer use NSS for SSL/Crypto, the debugging information for it is outdated and we no longer need to include the Valgrind Suppressions. BUG= 604728 Review URL: https://codereview.chromium.org/1921743002 Cr-Commit-Position: refs/heads/master@{#389808} [modify] https://crrev.com/72b40a33f27d3fb1757508c53cc7ffafa9e0d1bb/docs/linux_debugging_ssl.md [modify] https://crrev.com/72b40a33f27d3fb1757508c53cc7ffafa9e0d1bb/tools/valgrind/drmemory/suppressions_full.txt
Remaining Changes: Remove crypto/*_win files Merge //base/sha1 with BoringSSL Remove crypto/third_party/nss (CL 1913143002) Rename system.gyp:ssl (CL 1918303002)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4fed186b2068597ec3f942af3c6fca8f29d70d0 commit d4fed186b2068597ec3f942af3c6fca8f29d70d0 Author: svaldez <svaldez@chromium.org> Date: Mon May 02 16:21:11 2016 Renaming system.gyp:ssl to system.gyp:nss and removing unused BUILD.gn BUG= 604728 TBR=thakis@chromium.org, jbauman@chromium.org Review-Url: https://codereview.chromium.org/1918303002 Cr-Commit-Position: refs/heads/master@{#390962} [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/build/linux/system.gyp [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/build/secondary/third_party/nss/BUILD.gn [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/chrome/chrome_common.gypi [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/chrome/chrome_tests.gypi [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/chromeos/chromeos.gyp [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/components/ownership.gypi [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/content/browser/gpu/test_support_gpu.gypi [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/crypto/crypto.gyp [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/net/net.gyp [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/net/net_common.gypi [modify] https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0/tools/gn/docs/cookbook.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c641463a0755cfbbe827a62580dd9859c41806e commit 9c641463a0755cfbbe827a62580dd9859c41806e Author: svaldez <svaldez@chromium.org> Date: Mon May 02 20:49:05 2016 Removing crypto/third_party/nss/ and removing crypto _win files BUG= 604728 Review-Url: https://codereview.chromium.org/1924093006 Cr-Commit-Position: refs/heads/master@{#391048} [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/BUILD.gn [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/crypto.gyp [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/crypto.gypi [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/crypto_nacl.gyp [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/hmac.cc [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/hmac.h [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/hmac_openssl.cc [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/hmac_win.cc [rename] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/symmetric_key.cc [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/crypto/symmetric_key.h [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/symmetric_key_win.cc [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/LICENSE [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/README.chromium [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/chromium-blapi.h [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/chromium-blapit.h [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/chromium-nss.h [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/chromium-prtypes.h [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/chromium-sha256.h [delete] https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e/crypto/third_party/nss/sha512.cc [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/net/cert/x509_util_nss.cc [modify] https://crrev.com/9c641463a0755cfbbe827a62580dd9859c41806e/third_party/boringssl/boringssl.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd commit a3ad8d0bc490d62f9de55216f40f0135bdafd9dd Author: rsleevi <rsleevi@chromium.org> Date: Tue Jun 07 18:22:33 2016 Remove traces of USE_NSS_CERTS from crypto/ NSS is no longer an option as the cryptographic service provider - all platforms have transitioned to using BoringSSL. Any remaining files in crypto/ that use NSS will always have USE_NSS_CERTS set. This also fixes some unit tests that used the wrong ifdefs once everything was converted to use BoringSSL. BUG= 604728 Review-Url: https://codereview.chromium.org/2046863002 Cr-Commit-Position: refs/heads/master@{#398348} [modify] https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd/crypto/encryptor_unittest.cc [modify] https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd/crypto/nss_key_util.cc [modify] https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd/crypto/nss_key_util.h [modify] https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd/crypto/nss_key_util_unittest.cc [modify] https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd/crypto/nss_util.cc [modify] https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd/crypto/nss_util.h [modify] https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd/crypto/symmetric_key_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21fcb69c3825bb655f87f69ea6a8408616717253 commit 21fcb69c3825bb655f87f69ea6a8408616717253 Author: davidben <davidben@chromium.org> Date: Fri Oct 14 17:11:18 2016 Remove net::EnableSSLServerSockets. With NSS gone, this function is now a no-op. BUG= 604728 Review-Url: https://codereview.chromium.org/2405403002 Cr-Commit-Position: refs/heads/master@{#425366} [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/net/socket/ssl_server_socket.h [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/net/socket/ssl_server_socket_impl.cc [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/net/test/run_all_unittests.cc [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/remoting/DEPS [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/remoting/base/run_all_unittests.cc [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/remoting/host/it2me/it2me_native_messaging_host_main.cc [modify] https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253/remoting/host/remoting_me2me_host.cc
Comment 1 by davidben@chromium.org
, Apr 19 2016