New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604727 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Move context menu code from ui/base/ios/ to ios/chrome/browser/ui

Project Member Reported by jyqu...@chromium.org, Apr 19 2016

Issue description

iOS code should live in ios/. Moving contextual menu code to the ios directory before doing more work on contextual menus.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b64b9b67671fa06be5e3cebb55bef4bc2467b908

commit b64b9b67671fa06be5e3cebb55bef4bc2467b908
Author: jyquinn <jyquinn@chromium.org>
Date: Thu Apr 21 17:20:26 2016

Copy contents of ui/base/ios into ios/chrome/browser/ui/context_menu

Moving context menu code into ios/chrome/browser/ui as a part of
factoring link context menus out of BrowserViewController.
Step 1 of 3.

BUG= 604727 

Review URL: https://codereview.chromium.org/1891863004

Cr-Commit-Position: refs/heads/master@{#388800}

[modify] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/BUILD.gn
[modify] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/BUILD.gn
[add] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/context_menu/OWNERS
[add] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/context_menu/context_menu_controller.h
[add] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/context_menu/context_menu_controller.mm
[add] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/context_menu/context_menu_controller_unittest.mm
[add] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/context_menu/context_menu_holder.h
[add] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/context_menu/context_menu_holder.mm
[add] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/context_menu/context_menu_provider.h
[modify] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher_unittest.mm
[modify] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/ios_chrome.gyp
[modify] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/chrome/ios_chrome_tests.gyp
[modify] https://crrev.com/b64b9b67671fa06be5e3cebb55bef4bc2467b908/ios/web/web_state/ui/crw_web_controller.mm

Labels: -Hotlist-Tech-Debt Hotlist-TechnicalDebt
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e77a13a5166e1e7b8b836f5bb28f4aed05b5a663

commit e77a13a5166e1e7b8b836f5bb28f4aed05b5a663
Author: jyquinn <jyquinn@google.com>
Date: Thu Apr 21 22:51:13 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a5768d761d650a394bbea1bb8af41760f7417c

commit e1a5768d761d650a394bbea1bb8af41760f7417c
Author: jyquinn <jyquinn@chromium.org>
Date: Fri Apr 22 15:46:43 2016

Remove ui/base/ios

The contents of ui/base/ios, CRUContextMenuController and
CRUContextMenuHolder were moved to ios/chrome/browser/ui/context_menu.

This is part 3 of 3.

BUG= 604727 

Review URL: https://codereview.chromium.org/1885043012

Cr-Commit-Position: refs/heads/master@{#389118}

[modify] https://crrev.com/e1a5768d761d650a394bbea1bb8af41760f7417c/ios/web/web_state/ui/crw_context_menu_provider.h
[modify] https://crrev.com/e1a5768d761d650a394bbea1bb8af41760f7417c/ui/base/BUILD.gn
[delete] https://crrev.com/b794998819088f76b4cf44c8db6940240c563cf4/ui/base/ios/OWNERS
[delete] https://crrev.com/b794998819088f76b4cf44c8db6940240c563cf4/ui/base/ios/cru_context_menu_controller.h
[delete] https://crrev.com/b794998819088f76b4cf44c8db6940240c563cf4/ui/base/ios/cru_context_menu_controller.mm
[delete] https://crrev.com/b794998819088f76b4cf44c8db6940240c563cf4/ui/base/ios/cru_context_menu_controller_unittest.mm
[delete] https://crrev.com/b794998819088f76b4cf44c8db6940240c563cf4/ui/base/ios/cru_context_menu_holder.h
[delete] https://crrev.com/b794998819088f76b4cf44c8db6940240c563cf4/ui/base/ios/cru_context_menu_holder.mm
[modify] https://crrev.com/e1a5768d761d650a394bbea1bb8af41760f7417c/ui/base/ui_base.gyp
[modify] https://crrev.com/e1a5768d761d650a394bbea1bb8af41760f7417c/ui/base/ui_base_tests.gyp

Status: Fixed (was: Started)

Sign in to add a comment