PasswordManagerSettingMigratorServiceTest.ReconcileWhenWhenBothPrefsTypesArrivesFromSync fails on iOS |
|||
Issue descriptionThe file password_manager_setting_migrator_service_unittest.cc was not added to components/components_test.gyp when it was componentized (see https://codereview.chromium.org/1420533007). As a result the test was never ran on iOS and is now failing with the following error: [ RUN ] PasswordManagerSettingMigratorServiceTest.ReconcileWhenWhenBothPrefsTypesArrivesFromSync ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 15: 1 Actual: { Bucket 15: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 12: 1 Actual: { Bucket 12: 1, Bucket 15: 1 }, which has 2 elements Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 2 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 15: 1 Actual: { Bucket 15: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 2 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 12: 1 Actual: { Bucket 12: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 15: 1 Actual: { Bucket 15: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 0: 1 Actual: { Bucket 0: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 0 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 0: 1 Actual: { Bucket 0: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 0 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 3: 1 Actual: { Bucket 0: 1, Bucket 3: 1 }, which has 2 elements Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 0 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 3: 1 Actual: { Bucket 3: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 0 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 4: 1 Actual: { Bucket 4: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 0 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 4: 1 Actual: { Bucket 4: 1, Bucket 7: 1 }, which has 2 elements Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 0 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 7: 1 Actual: { Bucket 7: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 0 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 8: 1 Actual: { Bucket 8: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 2 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 8: 1 Actual: { Bucket 8: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 8: 1 Actual: { Bucket 8: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:201: Failure Value of: prefs()->GetBoolean(prefs::kCredentialsEnableService) Actual: false Expected: new_pref_value Which is: true Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:203: Failure Value of: prefs()->GetBoolean(prefs::kPasswordManagerSavingEnabled) Actual: false Expected: old_pref_value Which is: true Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 11: 1 Actual: { Bucket 8: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 12: 1 Actual: { Bucket 12: 1, Bucket 15: 1 }, which has 2 elements Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 2 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 15: 1 Actual: { Bucket 15: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 2 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 12: 1 Actual: { Bucket 12: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 12: 1 Actual: { Bucket 12: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 12: 1 Actual: { Bucket 12: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 0 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 15: 1 Actual: { Bucket 15: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 2 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 12: 1 Actual: { Bucket 12: 1, Bucket 15: 1 }, which has 2 elements Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 0 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:345: Failure Value of: tester.GetAllSamples(kInitialAndFinalValuesHistogramName) Expected: has 1 element that is equal to Bucket 15: 1 Actual: { Bucket 15: 2 }, whose element #0 doesn't match Google Test trace: ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:325: Sync data = 1 1 ../../components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc:322: Local data = 1 1 [ FAILED ] PasswordManagerSettingMigratorServiceTest.ReconcileWhenWhenBothPrefsTypesArrivesFromSync (17 ms) Since the test has never been run on iOS and this is blocking moving to gn, I'm going to disable the test on iOS in components/password_manager/sync/BUILD.gn. Please re-enable and add the test in components/components_test.gyp once this is fixed.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc commit a986d5d6c1c044953d81b1342ae6ab5e138c6ebc Author: sdefresne <sdefresne@chromium.org> Date: Tue Apr 19 18:19:23 2016 [GN/iOS] Explicitly list test data in //components. Since timestamp of directory is not always updated when the content is changed (e.g. when a file content is changed, ...) listing just the directory lead to flaky incremental builds and bot failures. Explicitly list all test data files to fix those flakes. To make it more manageable, create individual bundle_data for all unit_tests target that require them and put the individual files used there. Enable the same set of unit tests on iOS with gyp and gn and fix some minor errors in the BUILD.gn files to get the target to build and link. BUG= 459705 , 604721 Review URL: https://codereview.chromium.org/1903443002 Cr-Commit-Position: refs/heads/master@{#388248} [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/bookmarks/browser/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/data_reduction_proxy/core/browser/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/dom_distiller/core/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/history/core/browser/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/json_schema/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/omnibox/browser/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/security_state/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/update_client/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/user_prefs/tracked/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/webdata/common/BUILD.gn [modify] https://crrev.com/a986d5d6c1c044953d81b1342ae6ab5e138c6ebc/components/webp_transcode/BUILD.gn
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8 commit f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8 Author: melandory <melandory@chromium.org> Date: Wed Apr 20 09:06:51 2016 [Smart Lock] Fix settings reconciliation on ios. BUG= 604721 Review URL: https://codereview.chromium.org/1902113002 Cr-Commit-Position: refs/heads/master@{#388452} [modify] https://crrev.com/f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8/components/components_tests.gyp [modify] https://crrev.com/f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
,
Apr 20 2016
While the fix landed (#3), the test is still disabled (because of #2, see [1]). I'll upload a CL to enable it, run a two-sided patch to verify and land if all is green [1] https://chromium.googlesource.com/chromium/src/+/f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5760870a55360f410f3327597a1da57d1d806119 commit 5760870a55360f410f3327597a1da57d1d806119 Author: vabr <vabr@chromium.org> Date: Wed Apr 20 12:44:51 2016 Enable ReconcileWhenWhenBothPrefsTypesArrivesFromSync on iOS This CL enables PasswordManagerSettingMigratorServiceTest.ReconcileWhenWhenBothPrefsTypesArrivesFromSync on iOS, after https://codereview.chromium.org/1902113002/ fixed the test failure. BUG= 604721 Review URL: https://codereview.chromium.org/1902093005 Cr-Commit-Position: refs/heads/master@{#388476} [modify] https://crrev.com/5760870a55360f410f3327597a1da57d1d806119/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
,
Apr 20 2016
Thank you for quickly fixing the bug and re-enabling it after our CLs crossed in flight.
,
Nov 29
|
|||
►
Sign in to add a comment |
|||
Comment 1 by melandory@chromium.org
, Apr 19 2016