The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/55d4b04bb3bf906bd9b8a7e4156696e8324d6958

commit 55d4b04bb3bf906bd9b8a7e4156696e8324d6958
Author: noyau <noyau@google.com>
Date: Tue Apr 19 13:02:36 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/a2631066e589bd6d8efa210310f79444d76b0ef7

commit a2631066e589bd6d8efa210310f79444d76b0ef7
Author: noyau <noyau@google.com>
Date: Tue Apr 19 15:29:57 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7892c1041df97b3829a3d4e862e563fbdbbb817

commit c7892c1041df97b3829a3d4e862e563fbdbbb817
Author: noyau <noyau@chromium.org>
Date: Thu May 12 12:22:01 2016

Adding flags and finch trial for the removal of All Bookmarks view.

BUG= 604705 

Review-Url: https://codereview.chromium.org/1970163002
Cr-Commit-Position: refs/heads/master@{#393232}

[modify] https://crrev.com/c7892c1041df97b3829a3d4e862e563fbdbbb817/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/c7892c1041df97b3829a3d4e862e563fbdbbb817/ios/chrome/browser/chrome_switches.cc
[modify] https://crrev.com/c7892c1041df97b3829a3d4e862e563fbdbbb817/ios/chrome/browser/chrome_switches.h
[modify] https://crrev.com/c7892c1041df97b3829a3d4e862e563fbdbbb817/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/c7892c1041df97b3829a3d4e862e563fbdbbb817/ios/chrome/browser/experimental_flags.mm

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0662d41485cbbeb22714fd0a74c69f920d8c0360

commit 0662d41485cbbeb22714fd0a74c69f920d8c0360
Author: noyau <noyau@google.com>
Date: Thu May 12 20:57:38 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5dae09b83bdd0eb72665b1850a033ada6cf7708a

commit 5dae09b83bdd0eb72665b1850a033ada6cf7708a
Author: lpromero <lpromero@google.com>
Date: Fri May 13 00:51:05 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71a76b61eb14b5eb195d89badf95467026b639ea

commit 71a76b61eb14b5eb195d89badf95467026b639ea
Author: noyau <noyau@chromium.org>
Date: Fri May 13 13:02:10 2016

Keep All Bookmarks panel visible by default.

BUG= 604705 

Review-Url: https://codereview.chromium.org/1976903002
Cr-Commit-Position: refs/heads/master@{#393510}

[modify] https://crrev.com/71a76b61eb14b5eb195d89badf95467026b639ea/ios/chrome/browser/experimental_flags.mm

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/fa0c7879ae0f6195b23fc818640e89533588a265

commit fa0c7879ae0f6195b23fc818640e89533588a265
Author: noyau <noyau@google.com>
Date: Fri May 13 15:59:20 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0651363c7b20f6a88d9a95e6cee9d7a20e0eddc6

commit 0651363c7b20f6a88d9a95e6cee9d7a20e0eddc6
Author: noyau <noyau@google.com>
Date: Thu Jul 07 13:45:17 2016

Should we request a merge for the signin promo? I think we missed the M53 branch point, right?

Friendly ping about requesting a merge, Eric. Is that something you're planning to do?

Also, it looks like the promo goes past the rule line (see attached photo from latest Canary). Is that a known issue?

+ Louis who might be able to help 

Louis: do you know if a merge has been requested?

(Eli: Eric is OOO until July 22). 

Ah got it, thanks Mardini.

Sorry, just realized I attached the wrong picture in #10. Attached the correct picture of the current behavior to this comment.

I don't believe a merge has been requested for the promo yet, but perhaps we should fix that overlap bug before requesting one?

Deleted: IMG_1078.PNG 46.5 KB

	IMG_1078.PNG 46.5 KB View Download

https://chromereviews.googleplex.com/458497013 was not merged and is not present in 2785. Requesting now, Elias, please advise on if I should merge it or not.

Elias, can you file a new bug for the overlap? Thank you.

[Automated comment] We don't branch for M54 for another 43 days, was this request meant for M53?

Your change meets the bar and is auto-approved for M53 (branch: 2785)

I don't know if Eric wanted to close this out as "Fixed" yet, so re-assigning.

We can go ahead and merge the change in comment #8. I filed a separate bug about the overlap in Issue 627677 and marked it as blocking on this. We'll need to request a merge for that fix as well.

lpromero@ - we should be good to merge https://chromereviews.googleplex.com/458497013 now.

Right, I tried this morning with our tool to automate the cherry picks, but it's broken somehow. I need to do it manually.

I don't have a 2785 checkout and won't be able to do it before leaving for the 2 bank holidays. Would someone in the US be able to perform the cherry pick? Or can it wait Monday?

I think it's fine to wait until Monday. I'll be OOO starting tomorrow, but it's still pretty early in the branch for 53, so Monday should be fine.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/cb77b6bea53db29a1ce9ecb63d712fff7d7c9dc8

commit cb77b6bea53db29a1ce9ecb63d712fff7d7c9dc8
Author: Louis Romero <lpromero@google.com>
Date: Tue Jul 19 08:27:23 2016

Can we mark this as "Fixed" now? Has all the eng work been completed?