unable to pop in get_healthy_devserver |
|||
Issue descriptionJob: http://cautotest/afe/#tab_id=view_job&object_id=60551646 Stack trace: Traceback (most recent call last): File "/usr/local/autotest/server/server_job.py", line 646, in run self._execute_code(INSTALL_CONTROL_FILE, namespace) File "/usr/local/autotest/server/server_job.py", line 1182, in _execute_code execfile(code_file, namespace, namespace) File "/usr/local/autotest/server/control_segments/install", line 10, in <module> job.parallel_simple(install, machines, log=False) File "/usr/local/autotest/server/server_job.py", line 574, in parallel_simple return_results=return_results) File "/usr/local/autotest/server/subcommand.py", line 93, in parallel_simple function(arg) File "/usr/local/autotest/server/control_segments/install", line 7, in install afe_utils.machine_install_and_update_labels(host) File "/usr/local/autotest/server/afe_utils.py", line 192, in machine_install_and_update_labels image_name, host_attributes = host.machine_install(*args, **dargs) File "/usr/local/autotest/server/hosts/testbed.py", line 289, in machine_install build_url, _ = host.stage_build_for_install(build) File "/usr/local/autotest/server/hosts/adb_host.py", line 1151, in stage_build_for_install self.hostname) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 579, in resolve build, cls.get_available_devservers()) File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 507, in get_healthy_devserver devserver = devservers.pop(hash_index) AttributeError: 'tuple' object has no attribute 'pop'
,
Apr 19 2016
Looks like it was this change: https://chromium-review.googlesource.com/#/c/339218/
,
Apr 19 2016
Proposed fix: https://chromium-review.googlesource.com/339516
,
Apr 19 2016
Dan - if there is a better fix, let me know. Since I am time shifted it may make more sense for you to take this.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1127af6fde9d8fb944332acf51e1459176476ad commit b1127af6fde9d8fb944332acf51e1459176476ad Author: Dan Shi <dshi@google.com> Date: Tue Apr 19 15:39:09 2016 [autotest] Bug fix in get_available_devservers call. The call returns a tupple of devservers, can_retry. Only devservers value should be used for get_healthy_devserver call. BUG= chromium:604702 TEST=unittest Change-Id: I0e48ca653b14ca69700ccdc401bee11c917e818c Reviewed-on: https://chromium-review.googlesource.com/339564 Reviewed-by: Dan Shi <dshi@google.com> Commit-Queue: Dan Shi <dshi@google.com> Tested-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/b1127af6fde9d8fb944332acf51e1459176476ad/client/common_lib/cros/dev_server.py
,
Jul 6 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by krisr@chromium.org
, Apr 19 2016