New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604702 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

unable to pop in get_healthy_devserver

Project Member Reported by krisr@chromium.org, Apr 19 2016

Issue description

Job: http://cautotest/afe/#tab_id=view_job&object_id=60551646

Stack trace:
Traceback (most recent call last):
  File "/usr/local/autotest/server/server_job.py", line 646, in run
    self._execute_code(INSTALL_CONTROL_FILE, namespace)
  File "/usr/local/autotest/server/server_job.py", line 1182, in _execute_code
    execfile(code_file, namespace, namespace)
  File "/usr/local/autotest/server/control_segments/install", line 10, in <module>
    job.parallel_simple(install, machines, log=False)
  File "/usr/local/autotest/server/server_job.py", line 574, in parallel_simple
    return_results=return_results)
  File "/usr/local/autotest/server/subcommand.py", line 93, in parallel_simple
    function(arg)
  File "/usr/local/autotest/server/control_segments/install", line 7, in install
    afe_utils.machine_install_and_update_labels(host)
  File "/usr/local/autotest/server/afe_utils.py", line 192, in machine_install_and_update_labels
    image_name, host_attributes = host.machine_install(*args, **dargs)
  File "/usr/local/autotest/server/hosts/testbed.py", line 289, in machine_install
    build_url, _ = host.stage_build_for_install(build)
  File "/usr/local/autotest/server/hosts/adb_host.py", line 1151, in stage_build_for_install
    self.hostname)
  File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 579, in resolve
    build, cls.get_available_devservers())
  File "/usr/local/autotest/client/common_lib/cros/dev_server.py", line 507, in get_healthy_devserver
    devserver = devservers.pop(hash_index)
AttributeError: 'tuple' object has no attribute 'pop'
 

Comment 1 by krisr@chromium.org, Apr 19 2016

Labels: -Pri-3 Pri-1

Comment 2 by krisr@chromium.org, Apr 19 2016

Looks like it was this change:
  https://chromium-review.googlesource.com/#/c/339218/

Comment 4 by krisr@chromium.org, Apr 19 2016

Owner: krisr@chromium.org
Status: Started (was: Untriaged)
Dan - if there is a better fix, let me know.  Since I am time shifted it may make more sense for you to take this.  
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1127af6fde9d8fb944332acf51e1459176476ad

commit b1127af6fde9d8fb944332acf51e1459176476ad
Author: Dan Shi <dshi@google.com>
Date: Tue Apr 19 15:39:09 2016

[autotest] Bug fix in get_available_devservers call.

The call returns a tupple of devservers, can_retry. Only devservers value
should be used for get_healthy_devserver call.

BUG= chromium:604702 
TEST=unittest

Change-Id: I0e48ca653b14ca69700ccdc401bee11c917e818c
Reviewed-on: https://chromium-review.googlesource.com/339564
Reviewed-by: Dan Shi <dshi@google.com>
Commit-Queue: Dan Shi <dshi@google.com>
Tested-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/b1127af6fde9d8fb944332acf51e1459176476ad/client/common_lib/cros/dev_server.py

Comment 6 by krisr@chromium.org, Jul 6 2016

Status: Fixed (was: Started)

Sign in to add a comment