New issue
Advanced search Search tips

Issue 604692 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----



Sign in to add a comment

chrome_ios_unittests vs ios_chrome_unittests

Project Member Reported by noyau@chromium.org, Apr 19 2016

Issue description

I can never ever remember which one is upstream and which one is downstream.

Can we rename the downstream one so it's clearly named ios_internal_unittests
 
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/128479dd8f0af71c549e07a841347316cc509101

commit 128479dd8f0af71c549e07a841347316cc509101
Author: sdefresne <sdefresne@google.com>
Date: Mon May 30 16:52:42 2016

Status: Fixed (was: Assigned)
I used the wrong bug number when creating the issue, so I copied the message from the bot as comment #1.
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a828c28077a28e859df22109a4fd5630dc94c10f

commit a828c28077a28e859df22109a4fd5630dc94c10f
Author: sdefresne <sdefresne@chromium.org>
Date: Mon May 30 18:04:20 2016

Allow overridding "app_name" for "test" template on iOS.

Some downstream iOS unit tests requires the value of BUNDLE_ID_TEST_NAME
to correspond to the target name without any underscore, so let client
override the value of app_name until gyp support is dropped and the tests
can use the target name for value of BUNDLE_ID_TEST_NAME.

BUG= 604692 

Review-Url: https://codereview.chromium.org/2022813002
Cr-Commit-Position: refs/heads/master@{#396746}

[modify] https://crrev.com/a828c28077a28e859df22109a4fd5630dc94c10f/testing/test.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9d334822a983864c46ca5df4e1e5044130bc180c

commit 9d334822a983864c46ca5df4e1e5044130bc180c
Author: sdefresne <sdefresne@google.com>
Date: Sat Jun 04 13:23:29 2016

Sign in to add a comment