Issue metadata
Sign in to add a comment
|
inspector-protocol/layout-fonts/unicode-range-combining-chars-fallback.html failing on Webkit Linux MSAN |
||||||||||||||||||||||||
Issue descriptioninspector-protocol/layout-fonts/unicode-range-combining-chars-fallback.html is failing on the Webkit Linux MSAN bot since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/9574/
,
Apr 19 2016
No test expectations to update, since this is specifically a MSan error. The only CL in the range is https://codereview.chromium.org/1896833002, which in fact fixed another MSan error, and probably just uncovered this one.
,
Apr 19 2016
Oops, the rest of the snippet: ============================== 00:31:46.043 25802 Uninitialized value was created by a heap allocation 00:31:46.043 25802 #0 0x4aab22 in operator new[](unsigned long) ??:0 00:31:46.044 25802 #1 0x55382b6 in ReconstructGlyf third_party/woff2/src/woff2_dec.cc:447:40 00:31:46.044 25802 #2 0x55382b6 in ReconstructFont third_party/woff2/src/woff2_dec.cc:990:0 00:31:46.044 25802 #3 0x55382b6 in ConvertWOFF2ToTTF third_party/woff2/src/woff2_dec.cc:1355:0 00:31:46.044 25802 #4 0x5531ece in ?? third_party/woff2/src/woff2_dec.cc:1331:10 00:31:46.044 25802 #5 0x550ccd0 in ProcessWOFF2 third_party/ots/src/ots.cc:482:8 00:31:46.044 25802 #6 0x550ccd0 in Process third_party/ots/src/ots.cc:896:0 00:31:46.044 25802 #7 0x4a0a211 in sanitize third_party/WebKit/Source/platform/fonts/opentype/OpenTypeSanitizer.cpp:96:15 00:31:46.044 25802 #8 0x49af7f1 in create third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp:91:44 00:31:46.044 25802 #9 0xac85ebf in ensureCustomFontData third_party/WebKit/Source/core/fetch/FontResource.cpp:121:26 00:31:46.044 25802 #10 0xa629f45 in fontLoaded third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:87:5 00:31:46.044 25802 #11 0xac869ab in checkNotify third_party/WebKit/Source/core/fetch/FontResource.cpp:178:9 00:31:46.044 25802 #12 0xacd278d in finish third_party/WebKit/Source/core/fetch/Resource.cpp:348:5 00:31:46.044 25802 #13 0xad2629c in didFinishLoading third_party/WebKit/Source/core/fetch/ResourceLoader.cpp:337:5 00:31:46.044 25802 #14 0xe2cf725 in OnCompletedRequest content/child/web_url_loader_impl.cc:757:7 00:31:46.044 25802 #15 0xe239b35 in OnRequestComplete content/child/resource_dispatcher.cc:376:3 00:31:46.044 25802 #16 0xe240c8b in DispatchToMethodImpl<content::ResourceDispatcher *, void (content::ResourceDispatcher::*)(int, const ResourceMsg_RequestCompleteData &), int, ResourceMsg_RequestCompleteData, 0, 1> base/tuple.h:166:3 00:31:46.044 25802 #17 0xe240c8b in DispatchToMethod<content::ResourceDispatcher *, void (content::ResourceDispatcher::*)(int, const ResourceMsg_RequestCompleteData &), int, ResourceMsg_RequestCompleteData> base/tuple.h:173:0 00:31:46.044 25802 #18 0xe240c8b in DispatchToMethod<content::ResourceDispatcher, void (content::ResourceDispatcher::*)(int, const ResourceMsg_RequestCompleteData &), void, std::__1::tuple<int, ResourceMsg_RequestCompleteData> > ipc/ipc_message_templates.h:26:0 00:31:46.044 25802 #19 0xe240c8b in Dispatch<content::ResourceDispatcher, content::ResourceDispatcher, void, void (content::ResourceDispatcher::*)(int, const ResourceMsg_RequestCompleteData &)> ipc/ipc_message_templates.h:121:0 00:31:46.044 25802 #20 0xe2308dc in DispatchMessage content/child/resource_dispatcher.cc:507:5 00:31:46.044 25802 #21 0xe22e380 in OnMessageReceived content/child/resource_dispatcher.cc:124:3 00:31:46.044 25802 #22 0xe34f84b in Run<std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> > > base/bind_internal.h:159:12 00:31:46.044 25802 #23 0xe34f84b in MakeItSo<std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> > > base/bind_internal.h:321:0 00:31:46.044 25802 #24 0xe34f84b in Run base/bind_internal.h:372:0 00:31:46.044 25802 #25 0x11e7d017 in Run base/callback.h:397:12 00:31:46.045 25802 #26 0x11e7d017 in RunTask base/debug/task_annotator.cc:51:0 00:31:46.045 25802 #27 0xe326d2e in ProcessTaskFromWorkQueue components/scheduler/base/task_queue_manager.cc:289:3 00:31:46.045 25802 #28 0xe320f56 in DoWork components/scheduler/base/task_queue_manager.cc:201:13 00:31:46.045 25802 00:31:46.045 25802 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/build/slave/WebKit_Linux_MSAN/build/src/out/Release/content_shell+0x5543b94) 00:31:46.045 25802 Exiting 00:31:46.045 25802 [1/1] inspector-protocol/layout-fonts/unicode-range-combining-chars-fallback.html failed unexpectedly (renderer crashed)
,
Apr 19 2016
The uninitialized value from heap allocation in woff2_dec.cc:447 was introduced recently by https://codereview.chromium.org/1873123002, cc'ing owners.
,
Apr 19 2016
If I understand correctly, changes to woff2 must go to the Github repo first, and then updated in third_party/, so I'm not going to submit a quick fix. Owners, please have a look.
,
Apr 19 2016
+cc sheriffs.
,
Apr 19 2016
Can I merge this to the same issue reported by ClusterFuzz? I sent a patch to upstream repository, and it is under a review. Also, here is a chromium side local patch change. https://codereview.chromium.org/1895043002/ In third_party/woff2, we allow minor local patches, but it should be listed in README.chromium.
,
Apr 20 2016
Any updates? The bot is still red. (Sorry, I don't have permission to read the duped bug)
,
Apr 20 2016
Now the fix is in CQ, https://codereview.chromium.org/1895043002/ I thought when I merged a bug to another, members in the original bug should be added to the another automatically, but Monorail seems not to support it. Le me add you to it manually.
,
Apr 20 2016
Thanks! Yes, it normally does that, but it seems that in this case it didn't because of the restriction. Seems intentional to me, otherwise you could peek into restricted bugs by creating a new one and then marking it as duplicate! :) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by msramek@chromium.org
, Apr 19 2016