We shouldn't sync content settings to mobile if they aren't used there. This will cause privacy sensitive data to be stored on the device which the user will have no way of viewing/erasing/etc.
Well, if we're confident that a sufficient number of users has been migrated, we could remove the migration code from https://codereview.chromium.org/1240153002, and remove CONTENT_SETTINGS_TYPE_IMAGES from that DCHECK.
My guess is, the number of users who need to be migrated (i.e. who changed the default setting for images to be BLOCK in the short period of time) is not so big, and the migration code has been there for a very long time. So I tend to remove the migration code so that we can unregister CONTENT_SETTINGS_TYPE_IMAGES on Android completely.
For clarity, does this also change whether the PreferenceSpecifics corresponding to desktop-only content setting types get synced down to the local Sync Database on Android; or just what gets stored in JSON format in Preferences?
(Sorry for reviving this.)
Unfortunately, as it was clarified with the Sync team after we made this change, it only affects whether the data are written to the preferences. The data are still physically sent to the device.
Comment 1 by engedy@chromium.org
, Apr 22 2016