New issue
Advanced search Search tips

Issue 604629 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

BrowserTestNonsecureURLRequest.SecurityStyleChangedObserverNonsecureConnection is buggy

Project Member Reported by est...@chromium.org, Apr 19 2016

Issue description

This test doesn't actually test what it claims to be testing, because replacing URLRequestNonsecureConnection with URLRequestMockHTTPJob doesn't cause it to fail.

Also see https://codereview.chromium.org/1899003002/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22c33fdbe07b62bbdcd4c9c36f8e5fbfa3820bed

commit 22c33fdbe07b62bbdcd4c9c36f8e5fbfa3820bed
Author: estark <estark@chromium.org>
Date: Fri Apr 29 23:25:32 2016

Fix SecurityStyleChangedObserverNonsecureConnection test

This test originally tried to use a net::URLRequestMockHTTPJob subclass
(URLRequestNonsecureConnection) to mock a connection with obsolete TLS
settings, but due to some missing boilerplate,
URLRequestNonsecureConnections were never actually used, and the test
was rather nonsensical. URLRequestNonsecureConnection was removed as
dead code in https://codereview.chromium.org/1899003002/.

This CL adds URLRequestNonsecureConnection back in and adds the missing
boilerplate so that this class is actually used. The test now
meaningfully tests what it's supposed to test.

BUG= 604629 

Review-Url: https://codereview.chromium.org/1919773005
Cr-Commit-Position: refs/heads/master@{#390800}

[modify] https://crrev.com/22c33fdbe07b62bbdcd4c9c36f8e5fbfa3820bed/chrome/browser/ui/browser_browsertest.cc

Comment 2 by est...@chromium.org, Apr 29 2016

Labels: M-52
Status: Fixed (was: Assigned)
Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label

Sign in to add a comment