Issue 604624 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	dpa...@chromium.org
Closed:	Apr 2016
Cc:	nyerramilli@chromium.org dpa...@chromium.org
Components:	UI>Settings
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Mac
Pri:	1
Type:	Bug-Regression
Proj-MaterialDesign-WebUI M-51

Blocked on:
issue 603709

Regression: Reset overlay is misplaced on chrome://md-settings/advanced

Reported by dmascare...@etouch.net, Apr 19 2016

Issue description

Chrome Version:51.0.2704.19 (Official Build) 0add88a3aa2b8ecc95df9dd721dd5b05571e7a5b-refs/branch-heads/2704@{#121}
OS: All
 
What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/advanced 
2. Scrolldown the page and click on ‘Reset’,observe the overlay.

Actual: Reset overlay is misplaced.
Expected: Reset overlay should not be misplaced (i.e. It should be in centre position)

This is regression issue,broken in ‘M 51’ and will soon update the info:

Good build: 51.0.2692.0
Bad build: 51.0.2693.2

Actual_reset.mov
1.3 MB Download

EXP_reset.mov
1.7 MB Download

Comment 1 by dmascare...@etouch.net, Apr 19 2016

Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/8d5646fee7b3f77b11f6a2365647049c0606445a..d78dcc0a1f3148b070b0ae80f4ccc8ac8a53c090?pretty=fuller&n=100

Suspecting: r387633 ?

Kindly help to re-assign, if your changes are not cause for this issue.

Comment 2 by dpa...@chromium.org, Apr 19 2016

Blockedon: 603709

This UI is about to change in a way that will make this bug obsolete, see  crbug.com/603709

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c740e34d19834b978e7f6cfc91ec1d07b5e64b03

commit c740e34d19834b978e7f6cfc91ec1d07b5e64b03
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 21 18:11:27 2016

MD Settings: Reset profile dialog, display settings in new tab.

BUG= 603709 , 604624 

Review URL: https://codereview.chromium.org/1911573003

Cr-Commit-Position: refs/heads/master@{#388814}

[modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/resources/settings/reset_page/reset_browser_proxy.js
[modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/ui/webui/settings/reset_settings_handler.cc
[modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/ui/webui/settings/reset_settings_handler.h
[modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/test/data/webui/settings/reset_page_test.js

Comment 4 by dpa...@chromium.org, Apr 21 2016

Status: Fixed (was: Assigned)

►

Issue 604624 link

Issue metadata

Regression: Reset overlay is misplaced on chrome://md-settings/advanced

Issue description

Comment 1 by dmascare...@etouch.net, Apr 19 2016

Comment 1 Deleted

Comment 2 by dpa...@chromium.org, Apr 19 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Apr 21 2016

Comment 3 Deleted

Comment 4 by dpa...@chromium.org, Apr 21 2016

Comment 4 Deleted

Sign in to add a comment