New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604611 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
mef@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

BidirectionalStreamTest.TestBufferingWithTrailers is flaky under DrMemory

Project Member Reported by jyasskin@chromium.org, Apr 19 2016 
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4659/steps/memory%20test%3A%20net/logs/stdio, https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4652/steps/memory%20test%3A%20net/logs/stdio, and https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4648/steps/memory%20test%3A%20net/logs/stdio fail with the error:

[ RUN      ] BidirectionalStreamTest.TestBufferingWithTrailers
c:\b\build\slave\drm-cr\build\src\net\http\bidirectional_stream_unittest.cc(315): error: Value of: sequenced_data_->AllReadDataConsumed()
  Actual: false
Expected: true
[  FAILED  ] BidirectionalStreamTest.TestBufferingWithTrailers
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/728de1d41e5e2753b2954d74b290db727b20dfd8

commit 728de1d41e5e2753b2954d74b290db727b20dfd8
Author: jyasskin <jyasskin@chromium.org>
Date: Tue Apr 19 06:22:27 2016

Exclude BidirectionalStreamTest, which is flaky under DrMemory.

BUG= 604611 
TBR=xunjieli@chromium.org,mef@chromium.org,groby@chromium.org

Review URL: https://codereview.chromium.org/1899133002

Cr-Commit-Position: refs/heads/master@{#388146}

[modify] https://crrev.com/728de1d41e5e2753b2954d74b290db727b20dfd8/tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62f6782adc7b8f3a2b7fa8445975e828362aadbd

commit 62f6782adc7b8f3a2b7fa8445975e828362aadbd
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Jun 01 18:29:27 2016

Fix flaky BidirectionalStreamTest

This CL attempts to fix the flakiness observed on DrMemory bots by running
the current message loop until idle after resuming the sequence socket data.

R=mef@chromium.org

BUG= 604611 

Review-Url: https://codereview.chromium.org/2011183002
Cr-Commit-Position: refs/heads/master@{#397188}

[modify] https://crrev.com/62f6782adc7b8f3a2b7fa8445975e828362aadbd/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/62f6782adc7b8f3a2b7fa8445975e828362aadbd/tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt

Comment 3 by mef@chromium.org, Jun 13 2016 

Helen, is this fixed now, or does it need more work?

Comment 4 by xunji...@chromium.org, Jun 13 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment