New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604586 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
no longer active
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Meta] Material Design Feedback

Project Member Reported by apaci...@chromium.org, Apr 19 2016

Issue description

The MD feedback work will be done separately from the current feedback code. The following include initial changes that will unblock development.

See http://go/chrome-feedback.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1cc9584742caf8e0e89428608a9d2955aef2110

commit b1cc9584742caf8e0e89428608a9d2955aef2110
Author: apacible <apacible@chromium.org>
Date: Tue Apr 19 18:27:08 2016

[Feedback] Create directory and add OWNERS file.

The work to contextualize and materialize feedback will be done separately from the current c/b/r/feedback/.

BUG= 604586 

Review URL: https://codereview.chromium.org/1901913004

Cr-Commit-Position: refs/heads/master@{#388253}

[add] https://crrev.com/b1cc9584742caf8e0e89428608a9d2955aef2110/chrome/browser/resources/md_feedback/OWNERS

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4093a984eae153186300a8d23a1487e851ffc5e

commit c4093a984eae153186300a8d23a1487e851ffc5e
Author: apacible <apacible@chromium.org>
Date: Tue Apr 19 19:21:58 2016

Create feedback_ui watchlist and add self.

BUG= 604586 

Review URL: https://codereview.chromium.org/1897233003

Cr-Commit-Position: refs/heads/master@{#388270}

[modify] https://crrev.com/c4093a984eae153186300a8d23a1487e851ffc5e/WATCHLISTS

Status: Started (was: Assigned)
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Reopening for WebUI setup.
Project Member

Comment 7 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd38eea0cb43ae8f5b8dc7fb11161e2a6652e8a

commit 0fd38eea0cb43ae8f5b8dc7fb11161e2a6652e8a
Author: apacible <apacible@chromium.org>
Date: Fri May 27 22:15:27 2016

[MD Feedback] Create directory and add OWNERS file for WebUI.

The redesigned feedback will be newly served as a WebUI.

BUG= 604586 

Review-Url: https://codereview.chromium.org/2016103002
Cr-Commit-Position: refs/heads/master@{#396581}

[add] https://crrev.com/0fd38eea0cb43ae8f5b8dc7fb11161e2a6652e8a/chrome/browser/ui/webui/md_feedback/OWNERS

Cc: r...@chromium.org melodychu@chromium.org michae...@chromium.org
Cc: jainabhi...@chromium.org
Labels: Hotlist-ConOps

Comment 10 by r...@chromium.org, Jul 25 2016

Cc: afakhry@chromium.org

Comment 11 by st...@chromium.org, Aug 24 2016

Cc: st...@chromium.org

Comment 12 by st...@chromium.org, Aug 24 2016

Cc: -r...@chromium.org
Cc: r...@chromium.org
Cc: -st...@chromium.org
@apacible: Can you provide a status update for this feature?

Is MD feedback still under development? Is enable-md-feedback runtime flag becoming the default? When can we delete chrome/browser/resources/feedback/ folder?
Labels: Proj-MaterialDesign-WebUI
MD feedback is not actively being developed at the moment, and a lot of changes went in to the existing feedback app.
Are there plans to pick up the work again at some (not too distant) time frame? Or should we just delete this page for now, similar to chrome://md-policy which was also abandoned before completion, see [1]?

[1] https://chromium-review.googlesource.com/c/chromium/src/+/596780
Please check with apacible@
Cc: dpa...@chromium.org
We can delete this page. I will send out the appropriate cleanup CLs this week.
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e533c2308244a58808c39a06961eb34710ebc5d0

commit e533c2308244a58808c39a06961eb34710ebc5d0
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Sep 22 03:44:42 2017

Update WATCHLISTS.

Bug:  604586 
Change-Id: I7bf1ea23b30552cd93b77ff80c5e34a36abfe097
Reviewed-on: https://chromium-review.googlesource.com/669309
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503637}
[modify] https://crrev.com/e533c2308244a58808c39a06961eb34710ebc5d0/WATCHLISTS

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e0fb1a2ff90631ea9e8b1bf34be2be8d10375c5

commit 2e0fb1a2ff90631ea9e8b1bf34be2be8d10375c5
Author: Jennifer Apacible <apacible@chromium.org>
Date: Mon Oct 09 23:55:05 2017

Remove MD Feedback files.

Project is currently inactive.

Bug:  604586 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4be26b194d49f39c4d03a67bf3a79389ac2d2399
Reviewed-on: https://chromium-review.googlesource.com/669308
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507542}
[modify] https://crrev.com/2e0fb1a2ff90631ea9e8b1bf34be2be8d10375c5/chrome/browser/browser_resources.grd
[modify] https://crrev.com/2e0fb1a2ff90631ea9e8b1bf34be2be8d10375c5/chrome/browser/feedback/show_feedback_page.cc
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/resources/md_feedback/OWNERS
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/resources/md_feedback/compiled_resources2.gyp
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/resources/md_feedback/feedback.html
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/resources/md_feedback/feedback.js
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/resources/md_feedback/feedback_container.html
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/resources/md_feedback/feedback_container.js
[modify] https://crrev.com/2e0fb1a2ff90631ea9e8b1bf34be2be8d10375c5/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2e0fb1a2ff90631ea9e8b1bf34be2be8d10375c5/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/ui/webui/md_feedback/OWNERS
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.cc
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.h
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/ui/webui/md_feedback/md_feedback_ui.h
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.cc
[delete] https://crrev.com/cbd7b823f0d27463312c338cff69e97070b5d452/chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h
[modify] https://crrev.com/2e0fb1a2ff90631ea9e8b1bf34be2be8d10375c5/third_party/closure_compiler/compiled_resources2.gyp

Status: WontFix (was: Started)

Sign in to add a comment