RendererMainPlatformDelegate::PlatformInitialize (Windows) DPI Initialization Should Use WebScreenInfo |
||
Issue description
Today:
content/renderer/renderer_main_platform_delegate_win.cc
void RendererMainPlatformDelegate::PlatformInitialize() {
[...]
blink::WebFontRendering::setUseDirectWrite(use_direct_write);
blink::WebFontRendering::setDeviceScaleFactor(display::win::GetDPIScale());
}
setDeviceScaleFactor should use WebScreenInfo instead.
,
Apr 19 2017
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue. The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59136cd0495372d4c0a3b90e31b3866c50f31759 commit 59136cd0495372d4c0a3b90e31b3866c50f31759 Author: Dominik Röttsches <drott@chromium.org> Date: Mon May 28 08:58:07 2018 Remove passing through of device scale factor on Windows This code is not needed anymore after [1] in which the heuristics for optimized small font rendering settings where replaced by using the font's GASP OpenType table. [1] https://chromium.googlesource.com/chromium/src/+/5fd631a31c688954834fc1e297a67b4b1a4f08bc Bug: 604555 Change-Id: I38309ee2508748e15620c0341689fd4b65a18de0 Reviewed-on: https://chromium-review.googlesource.com/1070268 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#562212} [modify] https://crrev.com/59136cd0495372d4c0a3b90e31b3866c50f31759/content/ppapi_plugin/ppapi_plugin_main.cc [modify] https://crrev.com/59136cd0495372d4c0a3b90e31b3866c50f31759/content/renderer/renderer_main_platform_delegate_win.cc [modify] https://crrev.com/59136cd0495372d4c0a3b90e31b3866c50f31759/third_party/blink/public/web/win/web_font_rendering.h [modify] https://crrev.com/59136cd0495372d4c0a3b90e31b3866c50f31759/third_party/blink/renderer/core/layout/web_font_rendering_win.cc [modify] https://crrev.com/59136cd0495372d4c0a3b90e31b3866c50f31759/third_party/blink/renderer/platform/fonts/font_cache.cc [modify] https://crrev.com/59136cd0495372d4c0a3b90e31b3866c50f31759/third_party/blink/renderer/platform/fonts/font_cache.h |
||
►
Sign in to add a comment |
||
Comment 1 by robliao@chromium.org
, Apr 18 2016