New issue
Advanced search Search tips

Issue 604531 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 444231



Sign in to add a comment

Remove CHROMIUM_subscribe_uniform WebGL extension

Project Member Reported by bajones@chromium.org, Apr 18 2016

Issue description

The extension has been rejected by the WebGL working group and should no longer be exposed to Chrome.

(Sorry Owen!)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa5e16c558164eeb7430be1f9846abdf8580ff2d

commit fa5e16c558164eeb7430be1f9846abdf8580ff2d
Author: bajones <bajones@chromium.org>
Date: Fri Apr 22 06:28:44 2016

Removed implementation of CHROMIUM_subscribe_uniform

BUG= 604531 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1894313002

Cr-Commit-Position: refs/heads/master@{#389044}

[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/components/mus/gles2/command_buffer_driver.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/components/mus/gles2/command_buffer_local.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/browser/gpu/gpu_process_host_ui_shim.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/browser/gpu/gpu_process_host_ui_shim.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/common/gpu_host_messages.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/gpu/gpu_child_thread.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/public/browser/gpu_utils.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/public/browser/render_process_host.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/BUILD.gn
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_subscribe_uniform.txt
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/GLES2/gl2extchromium.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/BUILD.gn
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/gles2_cmd_format.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/gles2_cmd_utils_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/common/typemaps.gni
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/common/value_state.cc
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/common/value_state.h
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/common/value_state.mojom
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/common/value_state.typemap
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/context_group.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/context_group_unittest.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/context_state.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_decoder.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/service/gles2_cmd_decoder_unittest_valuebuffer.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_validation_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gpu_preferences.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gpu_switches.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/gpu_switches.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/in_process_command_buffer.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/service/in_process_command_buffer.h
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/service/valuebuffer_manager.cc
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/service/valuebuffer_manager.h
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/gpu/command_buffer/service/valuebuffer_manager_unittest.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer_common.gypi
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/command_buffer_service.gypi
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/gles2_conform_support/egl/display.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/gpu.gyp
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/common/gpu_command_buffer_traits.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/common/gpu_command_buffer_traits.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel_manager_delegate.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_channel_test_common.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_command_buffer_stub.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/gpu/ipc/service/gpu_command_buffer_stub.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/mojo/gpu/mojo_gles2_impl_autogen.cc
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/mojo/gpu/mojo_gles2_impl_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/mojo/public/c/gles2/gles2_call_visitor_chromium_extension_autogen.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/modules.gypi
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/third_party/WebKit/Source/modules/webgl/CHROMIUMSubscribeUniform.cpp
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/third_party/WebKit/Source/modules/webgl/CHROMIUMSubscribeUniform.h
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/third_party/WebKit/Source/modules/webgl/CHROMIUMSubscribeUniform.idl
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.cpp
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.h
[delete] https://crrev.com/58e063f0f7b247f38c2448964a2ff4e62136dfa5/third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.idl
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/webgl/WebGLExtensionName.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c00d916965e57173ee12a48d5234877a7157d8a

commit 9c00d916965e57173ee12a48d5234877a7157d8a
Author: bajones <bajones@chromium.org>
Date: Fri Apr 22 18:34:03 2016

Removed gpu::ValueState from IPC fuzzer

Accidentally got left over from removal of CHROMIUM_subscribe_uniform extension.

BUG= 604531 

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1906403003

Cr-Commit-Position: refs/heads/master@{#389178}

[modify] https://crrev.com/9c00d916965e57173ee12a48d5234877a7157d8a/tools/ipc_fuzzer/fuzzer/fuzzer.cc

Status: Fixed (was: Untriaged)

Comment 4 by kbr@chromium.org, Feb 17 2017

Blocking: 444231

Sign in to add a comment