incorrect link in gerrit comment from precq |
||||
Issue descriptionSee https://bugs.chromium.org/p/chromium/issues/detail?id=603151 Format of the URL is wrong It is: https://uberchromegw.corp.google.com/i/chromeos/builders/Pre-CQ%20Launcher/builds/6741 Should be lower case and no %20 https://uberchromegw.corp.google.com/i/chromeos/builders/pre-cq-launcher/builds/6744
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/edb836f34718344663d0c23dcbd0a23318d980bf commit edb836f34718344663d0c23dcbd0a23318d980bf Author: Aviv Keshet <akeshet@chromium.org> Date: Tue Apr 19 17:55:08 2016 pre-cq: Fix incorrect link back to pre-cq builder. Following our mass rename of builders on the waterfall, this incorrect string was left behind. Fix the string in constants.py, and also make PreCQLauncherStage no longer use the constant anyway, but rather use self.GetBuilderName. (I couldn't eliminate the constant entirely because it is still referenced in some other places for minor things) BUG= chromium:604527 TEST=unit tests Change-Id: I35d740ebd793dc2f4f97527906da1b6c4760342d Reviewed-on: https://chromium-review.googlesource.com/339671 Commit-Ready: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/edb836f34718344663d0c23dcbd0a23318d980bf/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/edb836f34718344663d0c23dcbd0a23318d980bf/cbuildbot/constants.py
,
Apr 25 2016
,
Apr 27 2016
,
Aug 12 2016
Closing. please reopen if its not fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by akes...@chromium.org
, Apr 19 2016