New issue
Advanced search Search tips

Issue 604524 link

Starred by 0 users
Status: Verified
Owner:
dmazz...@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Android accessibility should not handle "load complete" on iframes

Project Member Reported by dmazz...@chromium.org, Apr 18 2016 
To repro:

1. Turn on TalkBack
2. Open Chrome and load CNN.com
3. The main page is supposed to focus when it finishes loading. Instead it focuses a dozen times, one for each iframe that loads. If you have haptic feedback enabled you'll feel it bump a bunch of times, it's very distracting.

Issue:

On Android we handle the "Load complete" event in a particular way that's intended for the main frame.

We shouldn't handle the main frame that way. Visiting cnn.com generates a bunch of load complete events.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93972adf9120670ef5c6c42b609aeeeb4bc41ad4

commit 93972adf9120670ef5c6c42b609aeeeb4bc41ad4
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Apr 21 21:04:33 2016

Only fire accessible load complete events on the main frame on Android.

BUG= 604524 

Review URL: https://codereview.chromium.org/1894113003

Cr-Commit-Position: refs/heads/master@{#388896}

[modify] https://crrev.com/93972adf9120670ef5c6c42b609aeeeb4bc41ad4/content/browser/accessibility/browser_accessibility_manager_android.cc

Comment 2 by dmazz...@chromium.org, Apr 21 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 4 by acindhe@chromium.org, Apr 26 2016 

Issue still repro on latest M51 - 51.0.2704.28. 

Moto g 2nd ganeration /6.0 , Nexus 5 / MOB30I
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 28 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ac6c714fe963c31fcc81a9ec60822741efd6b3a

commit 7ac6c714fe963c31fcc81a9ec60822741efd6b3a
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Apr 28 22:53:07 2016

Merge to M51: Only fire accessible load complete events on the main frame on Android.

BUG= 604524 

Review URL: https://codereview.chromium.org/1894113003

Cr-Commit-Position: refs/heads/master@{#388896}
(cherry picked from commit 93972adf9120670ef5c6c42b609aeeeb4bc41ad4)

Review URL: https://codereview.chromium.org/1927953003 .

Cr-Commit-Position: refs/branch-heads/2704@{#296}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/7ac6c714fe963c31fcc81a9ec60822741efd6b3a/content/browser/accessibility/browser_accessibility_manager_android.cc

Comment 6 by dmazz...@chromium.org, Apr 29 2016

Status: Fixed (was: Started)

Comment 7 by acindhe@chromium.org, May 4 2016

Status: Verified (was: Fixed)
Issue does not repro on latest build M51 - 51.0.2704.36 . Hence closing this issue. Thanks
►

Sign in to add a comment