Need behavior / list of settings that should be shown in these cases.
Issue 610390 has been merged into this issue.
I put together a spreadsheet that captures what happens in old settings when entering Guest Mode (to the best of my knowledge): https://docs.google.com/spreadsheets/d/1UGcdqjANLeNK0LN1JOynmLyYT9rlyYRGKMFop_7Sekw/edit#gid=68143056 Removing the mention of Incognito because we want to the same behavior as today (sending the user to a normal window with chrome://settings open)
I propose hiding, instead of disabling, most of the settings that aren't relevant in Guest Mode. Can we do that? is that behavior specced out already?
Issue 623444 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/369fb42299c568256ce9c8821967b9c413ea4151 commit 369fb42299c568256ce9c8821967b9c413ea4151 Author: mahmadi <mahmadi@chromium.org> Date: Wed Jul 27 13:36:51 2016 MD Settings: cr/cros - Guest mode page visibility BUG= 604517 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2106103006 Cr-Commit-Position: refs/heads/master@{#408112} [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/advanced_page/advanced_page.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/appearance_page/appearance_page.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/date_time_page/compiled_resources2.gyp [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/date_time_page/date_time_page.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/date_time_page/date_time_page.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/downloads_page/compiled_resources2.gyp [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/downloads_page/downloads_page.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/downloads_page/downloads_page.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_ui/settings_ui.html [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_ui/settings_ui.js [add] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/settings_ui/settings_ui_types.js [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/369fb42299c568256ce9c8821967b9c413ea4151/chrome/test/data/webui/settings/settings_subpage_browsertest.js
Languages aren't hidden but when you try to add one the list is empty. I'll file a separate bug
Comment 1 by engedy@chromium.org
, Apr 22 2016