New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604514 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

need to measure the effect of ICF (identical code folding) for Chrome on ChromeOS

Project Member Reported by llozano@chromium.org, Apr 18 2016

Issue description

We need to measure the effect of ICF on Chrome for ChromeOS. 
Since we are using PIE, the effect may not be much.
Sri has some ideas on how to improve ICF in combination with PIE.
Lets see how much are we getting now. 
Also, why hasn't anyone complained about the possible stack traces issue?


 
Cc: tmsriram@google.com
Status: Assigned (was: Untriaged)
BTW, I think we have ICF and PIE turned on for Chrome Linux.
has anyone complained about stack traces issues on Chrome for Linux?
Probably here and there, but I didn't find any examples when querying crbug.com for: OS=Linux ICF backtrace. Also tried s/backtrace/stacktrace/
Some data about Chrome size:
                   with icf                without icf
on arm:             75277531                   80324343       
on x86_64           105057474                  112265666

Comment 6 by tmsriram@google.com, Apr 19 2016

I assume this is with --icf=safe right?  Would you mind measuring with
--icf=all too if it is not too much trouble?

Thanks
Sri
This is --icf=all. Do you need the data for --icf=safe?

Comment 8 by tmsriram@google.com, Apr 19 2016

Oh ok. No, that is fine. --icf=all is the best you can get. Thanks for
clarifying that.

Sri
do you want the data without PIE?
No, thanks.  The reason I asked originally is because I suspected you
are using --icf=safe which does not give good code size reductions
with PIE.  If you are using --icf=all you are getting the best from
ICF.

Thanks
Sri
Status: Fixed (was: Assigned)
Close this?
Bulk verified
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment