New issue
Advanced search Search tips

Issue 604503 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Team-Security-UX

Blocking:
issue 559839



Sign in to add a comment

Move permission.mojom from WebKit/public/platform/ to components/

Project Member Reported by xhw...@chromium.org, Apr 18 2016

Issue description

In https://codereview.chromium.org/1771743002 permission mojoms were moved from content/ to WebKit/public/platform/.

As discussed in https://chromiumcodereview.appspot.com/1838903007/, "media" needs Permission services as well. Note that "media" doesn't depend on "content", nor "blink". The current proposal is to move Permission mojom into components/permission so that it can be accessed by other components in chromium.
 

Comment 1 by xhw...@chromium.org, Apr 18 2016

Labels: -Pri-3 M-52 Pri-2
Let me know if there are any objections to the idea.

sammc: Since you already did the move from content/ to WebKit/public/platform/, would you be interested in moving it again to components/ since you are already familiar with it?

Comment 2 by xhw...@chromium.org, Apr 25 2016

Cc: mlamouri@chromium.org
Owner: xhw...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b751521d3f027742f8f2b95fc814820977fc7a4

commit 1b751521d3f027742f8f2b95fc814820977fc7a4
Author: xhwang <xhwang@chromium.org>
Date: Tue May 03 08:17:07 2016

Move permission.mojom from WebKit/public/platform/ to components/

Mojo permission interface is needed by other parts of Chromium, e.g. media.
Hence move it to a more common place.

BUG=604503
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1921553003
Cr-Commit-Position: refs/heads/master@{#391185}

[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/blimp/engine/app/blimp_permission_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/blimp/engine/app/blimp_permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/DEPS
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/push_messaging/push_messaging_permission_context.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/push_messaging/push_messaging_permission_context.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/OWNERS
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/components.gyp
[add] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions.gypi
[add] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions/BUILD.gn
[add] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions/OWNERS
[rename] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions/permission.mojom
[rename] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions/permission_status.mojom
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/DEPS
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/DEPS
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/media/cdm/browser_cdm_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/permissions/permission_service_context.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/permissions/permission_service_context.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/child/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/child/notifications/notification_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/child/permissions/permission_dispatcher.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/common/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/common/DEPS
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/common/platform_notification_messages.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/content_browser.gypi
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/content_renderer.gypi
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/public/browser/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/public/browser/permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/public/common/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/geolocation_dispatcher.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/geolocation_dispatcher.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/media/media_permission_dispatcher.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/notification_permission_dispatcher.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/layout_test/layout_test_message_filter.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/layout_test/layout_test_message_filter.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/test/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/test/mock_permission_manager.cc
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/content/test/mock_permission_manager.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/Source/modules/notifications/DEPS
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[add] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/public/web/modules/notifications/DEPS
[modify] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h

Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954

commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954
Author: henrika <henrika@chromium.org>
Date: Tue May 03 09:21:20 2016

Revert of Move permission.mojom from WebKit/public/platform/ to components/ (patchset #8 id:140001 of https://codereview.chromium.org/1921553003/ )

Reason for revert:
Breaks Chrome building:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/43931/steps/compile/logs/stdio

Original issue's description:
> Move permission.mojom from WebKit/public/platform/ to components/
>
> Mojo permission interface is needed by other parts of Chromium, e.g. media.
> Hence move it to a more common place.
>
> BUG=604503
> TEST=No functionality change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4
> Cr-Commit-Position: refs/heads/master@{#391185}

TBR=dcheng@chromium.org,jam@chromium.org,mlamouri@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604503

Review-Url: https://codereview.chromium.org/1940223002
Cr-Commit-Position: refs/heads/master@{#391186}

[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/blimp/engine/app/blimp_permission_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/blimp/engine/app/blimp_permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/DEPS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/push_messaging/push_messaging_permission_context.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/push_messaging/push_messaging_permission_context.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/components/OWNERS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/components/components.gyp
[delete] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions.gypi
[delete] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions/BUILD.gn
[delete] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/components/permissions/OWNERS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/DEPS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/DEPS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/media/cdm/browser_cdm_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/permissions/permission_service_context.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/permissions/permission_service_context.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/child/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/child/notifications/notification_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/child/permissions/permission_dispatcher.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/common/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/common/DEPS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/common/platform_notification_messages.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/content_browser.gypi
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/content_renderer.gypi
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/public/browser/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/public/browser/permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/public/common/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/geolocation_dispatcher.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/geolocation_dispatcher.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/media/media_permission_dispatcher.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/notification_permission_dispatcher.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/layout_test/layout_test_message_filter.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/layout_test/layout_test_message_filter.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/test/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/test/mock_permission_manager.cc
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/content/test/mock_permission_manager.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/Source/modules/notifications/DEPS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[rename] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/public/platform/modules/permissions/permission.mojom
[rename] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/public/platform/modules/permissions/permission_status.mojom
[delete] https://crrev.com/1b751521d3f027742f8f2b95fc814820977fc7a4/third_party/WebKit/public/web/modules/notifications/DEPS
[modify] https://crrev.com/e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954/third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3b224aa8873e952b12a9d058155e2070a4c4305

commit f3b224aa8873e952b12a9d058155e2070a4c4305
Author: xhwang <xhwang@chromium.org>
Date: Wed May 04 04:07:35 2016

(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR=mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1942353002
Cr-Commit-Position: refs/heads/master@{#391441}

[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/blimp/engine/app/blimp_permission_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/blimp/engine/app/blimp_permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/DEPS
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/push_messaging/push_messaging_permission_context.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/push_messaging/push_messaging_permission_context.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/components/OWNERS
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/components/components.gyp
[add] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/components/permissions.gypi
[add] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/components/permissions/BUILD.gn
[add] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/components/permissions/OWNERS
[rename] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/components/permissions/permission.mojom
[rename] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/components/permissions/permission_status.mojom
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/DEPS
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/DEPS
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/media/cdm/browser_cdm_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/permissions/permission_service_context.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/permissions/permission_service_context.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/child/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/child/notifications/notification_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/child/permissions/permission_dispatcher.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/common/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/common/DEPS
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/common/platform_notification_messages.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/content_browser.gypi
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/content_child.gypi
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/content_common.gypi
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/content_renderer.gypi
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/content_shell.gypi
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/content_tests.gypi
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/public/browser/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/public/browser/permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/public/common/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/geolocation_dispatcher.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/geolocation_dispatcher.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/media/media_permission_dispatcher.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/notification_permission_dispatcher.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/layout_test/layout_test_message_filter.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/layout_test/layout_test_message_filter.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/test/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/test/mock_permission_manager.cc
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/content/test/mock_permission_manager.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/Source/modules/notifications/DEPS
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[add] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/public/web/modules/notifications/DEPS
[modify] https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305/third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc29ae54a418e18ce2f8b9912641f75d560ae5c8

commit cc29ae54a418e18ce2f8b9912641f75d560ae5c8
Author: mathp <mathp@chromium.org>
Date: Wed May 04 15:22:17 2016

Revert of (reland) Move permission.mojom from WebKit/public/platform/ to components/ (patchset #3 id:40001 of https://codereview.chromium.org/1942353002/ )

Reason for revert:
Sorry, it's causing failures on many bots, reliably on Google Chrome OS bot:

https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=17561

Original issue's description:
> (reland) Move permission.mojom from WebKit/public/platform/ to components/
>
> This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.
>
> Mojo permission interface is needed by other parts of Chromium, e.g.
> media.
> Hence move it to a more common place.
>
> BUG=604503
> TBR=mlamouri@chromium.org,dcheng@chromium.org
> TEST=No functionality change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305
> Cr-Commit-Position: refs/heads/master@{#391441}

TBR=jam@chromium.org,dcheng@chromium.org,mlamouri@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604503

Review-Url: https://codereview.chromium.org/1943963004
Cr-Commit-Position: refs/heads/master@{#391514}

[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/blimp/engine/app/blimp_permission_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/blimp/engine/app/blimp_permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/DEPS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/push_messaging/push_messaging_permission_context.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/push_messaging/push_messaging_permission_context.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/components/OWNERS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/components/components.gyp
[delete] https://crrev.com/b85739418110c965b04c9d9198e2e6bdb0351443/components/permissions.gypi
[delete] https://crrev.com/b85739418110c965b04c9d9198e2e6bdb0351443/components/permissions/BUILD.gn
[delete] https://crrev.com/b85739418110c965b04c9d9198e2e6bdb0351443/components/permissions/OWNERS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/DEPS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/DEPS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/media/cdm/browser_cdm_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/permissions/permission_service_context.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/permissions/permission_service_context.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/child/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/child/notifications/notification_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/child/permissions/permission_dispatcher.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/common/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/common/DEPS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/common/platform_notification_messages.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/content_browser.gypi
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/content_child.gypi
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/content_common.gypi
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/content_renderer.gypi
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/content_shell.gypi
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/content_tests.gypi
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/public/browser/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/public/browser/permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/public/common/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/geolocation_dispatcher.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/geolocation_dispatcher.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/media/media_permission_dispatcher.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/notification_permission_dispatcher.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/layout_test/layout_test_message_filter.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/layout_test/layout_test_message_filter.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/test/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/test/mock_permission_manager.cc
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/content/test/mock_permission_manager.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/Source/modules/notifications/DEPS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[rename] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/public/platform/modules/permissions/permission.mojom
[rename] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/public/platform/modules/permissions/permission_status.mojom
[delete] https://crrev.com/b85739418110c965b04c9d9198e2e6bdb0351443/third_party/WebKit/public/web/modules/notifications/DEPS
[modify] https://crrev.com/cc29ae54a418e18ce2f8b9912641f75d560ae5c8/third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h

Comment 7 by xhw...@chromium.org, May 26 2016

Labels: -M-52 M-53
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 13 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by xhw...@chromium.org, Aug 26 2016

Labels: M55
Labels: -M55 M-55
Labels: -M-54
Should this be marked as Fixed?
Labels: -M-55 -MovedFrom-53
Status: Assigned (was: Started)
No, my CL was reverted and I didn't have time to reland the CL with fix.
Components: Internals>Permissions>Model
Components: -Internals>Permissions
Labels: Hotlist-EnamelAndFriendsFixIt
Labels: -Hotlist-EnamelAndFriendsFixIt
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment